From: Corinna Vinschen <vinschen@redhat.com>
To: newlib@sourceware.org
Subject: Re: [PATCH] Remove use of _global_impure_ptr
Date: Wed, 4 May 2022 15:34:28 +0200 [thread overview]
Message-ID: <YnKA5PIoceqyRnYl@calimero.vinschen.de> (raw)
In-Reply-To: <20220503134043.122345-1-sebastian.huber@embedded-brains.de>
Hi Sebastian,
On May 3 15:40, Sebastian Huber wrote:
> Remove the pointer indrection through the read-only _global_impure_ptr and
> directly use a globally visible _impure_data object of type struct reent. This
> enables the static initialization of global data structures in a follow up
> patch. In addition, we get rid of a machine-specific file.
the patch looks good. I just wonder if we really need the
impure-compat.c file. Backward-compat is no problem for embedded stuff,
and Cygwin doesn't expose _global_impure_ptr to user space either.
If there's no other compelling reason, you can just drop it and push
the rest.
Thanks,
Corinna
next prev parent reply other threads:[~2022-05-04 13:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-03 13:40 Sebastian Huber
2022-05-04 13:34 ` Corinna Vinschen [this message]
2022-05-04 13:38 ` Sebastian Huber
2022-05-04 15:22 ` Dave Nadler
2022-05-04 15:29 ` Sebastian Huber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YnKA5PIoceqyRnYl@calimero.vinschen.de \
--to=vinschen@redhat.com \
--cc=newlib@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).