From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 8B54D3857831 for ; Wed, 4 May 2022 13:34:31 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 8B54D3857831 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1651671271; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=8qaSgzSXu4AWw6pfqOFM1XcMdM+99Fp5SF8Ayh9PrAk=; b=OdGWjCztlvlHApv3eozXR0n/tPRM/ZdYQF0VqnkhYWb5o6yERjBe8OUrCBzn3At5BRu9F7 p4FrHOhzkFH93PbjejRdLaBGHdpbZ13XbAyVTbrVBRBWOskcyd1TI2Bx/ISKzjWOJFaK5J /18JIX4HFOTd05DkCkOera73LLeGx1M= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-540-2Zh-uqAFMNCgG0vwVl1L6g-1; Wed, 04 May 2022 09:34:30 -0400 X-MC-Unique: 2Zh-uqAFMNCgG0vwVl1L6g-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id F29D8802819 for ; Wed, 4 May 2022 13:34:29 +0000 (UTC) Received: from calimero.vinschen.de (unknown [10.36.112.5]) by smtp.corp.redhat.com (Postfix) with ESMTPS id CE53040CFD32 for ; Wed, 4 May 2022 13:34:29 +0000 (UTC) Received: by calimero.vinschen.de (Postfix, from userid 500) id 81F4BA80884; Wed, 4 May 2022 15:34:28 +0200 (CEST) Date: Wed, 4 May 2022 15:34:28 +0200 From: Corinna Vinschen To: newlib@sourceware.org Subject: Re: [PATCH] Remove use of _global_impure_ptr Message-ID: Reply-To: newlib@sourceware.org Mail-Followup-To: newlib@sourceware.org References: <20220503134043.122345-1-sebastian.huber@embedded-brains.de> MIME-Version: 1.0 In-Reply-To: <20220503134043.122345-1-sebastian.huber@embedded-brains.de> X-Scanned-By: MIMEDefang 2.84 on 10.11.54.1 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=vinschen@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Spam-Status: No, score=-5.2 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: newlib@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Newlib mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 May 2022 13:34:32 -0000 Hi Sebastian, On May 3 15:40, Sebastian Huber wrote: > Remove the pointer indrection through the read-only _global_impure_ptr and > directly use a globally visible _impure_data object of type struct reent. This > enables the static initialization of global data structures in a follow up > patch. In addition, we get rid of a machine-specific file. the patch looks good. I just wonder if we really need the impure-compat.c file. Backward-compat is no problem for embedded stuff, and Cygwin doesn't expose _global_impure_ptr to user space either. If there's no other compelling reason, you can just drop it and push the rest. Thanks, Corinna