public inbox for newlib@sourceware.org
 help / color / mirror / Atom feed
From: Corinna Vinschen <vinschen@redhat.com>
To: newlib@sourceware.org
Subject: Re: [PATCH 08/11] Add stdio atexit handler
Date: Wed, 11 May 2022 17:23:24 +0200	[thread overview]
Message-ID: <YnvU7HB3dq/aAc4D@calimero.vinschen.de> (raw)
In-Reply-To: <20220510080927.28839-9-matthew.joyce@embedded-brains.de>

On May 10 10:09, Matthew Joyce wrote:
> From: Matt Joyce <matthew.joyce@embedded-brains.de>
> 
> Add a dedicated stdio atexit handler to avoid using _GLOBAL_REENT in exit().

The idea is ok, I would just prefer to use another name. The reason is
that an unsuspecting user could assume that this function actually gets
added to the atexit functions. What about stdio_exit_handler()?


Corinna


  reply	other threads:[~2022-05-11 15:23 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-10  8:09 [PATCH 00/11] Decouple global file object list from _GLOBAL_REENT Matthew Joyce
2022-05-10  8:09 ` [PATCH 01/11] Remove duplicate stdio initializations Matthew Joyce
2022-05-10  8:09 ` [PATCH 02/11] Remove duplicate sglue initializations Matthew Joyce
2022-05-10  8:09 ` [PATCH 03/11] Declare global __sf[] only once Matthew Joyce
2022-05-10  8:09 ` [PATCH 04/11] Add two __sglue initialization macros Matthew Joyce
2022-05-10  8:09 ` [PATCH 05/11] Remove __sinit_locks / __sinit_recursive_mutex Matthew Joyce
2022-05-10  8:09 ` [PATCH 06/11] Move __sglue initializations to __sfp() Matthew Joyce
2022-05-10  8:09 ` [PATCH 07/11] Add CLEANUP_FILE define Matthew Joyce
2022-05-10  8:09 ` [PATCH 08/11] Add stdio atexit handler Matthew Joyce
2022-05-11 15:23   ` Corinna Vinschen [this message]
2022-05-11 16:54     ` Corinna Vinschen
2022-05-11 17:51       ` Sebastian Huber
2022-05-11 17:51     ` Sebastian Huber
2022-05-10  8:09 ` [PATCH 09/11] stdio: Replace _fwalk_reent() with _fwalk_sglue() Matthew Joyce
2022-05-11 15:56   ` Corinna Vinschen
2022-05-11 17:55     ` Sebastian Huber
2022-05-12  7:59       ` Corinna Vinschen
2022-05-10  8:09 ` [PATCH 10/11] Add global __sglue object for all configurations Matthew Joyce
2022-05-10  8:09 ` [PATCH 11/11] Remove __sglue member for one configuration Matthew Joyce

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YnvU7HB3dq/aAc4D@calimero.vinschen.de \
    --to=vinschen@redhat.com \
    --cc=newlib@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).