From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 315F33858CDA for ; Wed, 11 May 2022 16:54:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 315F33858CDA Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1652288059; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TsoxlSHhKLA1bRq6mMgcYkcs98solhuNGnRqdhr+4iA=; b=YyMK5OhRFCa6EY2oM1WRbiYemStF6MMg4dKio9lp25+SHZT+k0SSRaKu9TXs+DGMrAKzq4 cQ3ruRBKu2b2VCiyavmcI6aQd1ZE4azDBqrHhi0HUpCy03GvrHd2YTC+alXd318y5QhSrK 8O5q2wsGeINbZUojDRCf1mqoca0jMz4= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-327-37gRpgyKNOyFn9om1jmHgQ-1; Wed, 11 May 2022 12:54:18 -0400 X-MC-Unique: 37gRpgyKNOyFn9om1jmHgQ-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 6923C1D32365 for ; Wed, 11 May 2022 16:54:17 +0000 (UTC) Received: from calimero.vinschen.de (unknown [10.36.112.8]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 456902166B46 for ; Wed, 11 May 2022 16:54:17 +0000 (UTC) Received: by calimero.vinschen.de (Postfix, from userid 500) id 10B6DA80741; Wed, 11 May 2022 18:54:16 +0200 (CEST) Date: Wed, 11 May 2022 18:54:16 +0200 From: Corinna Vinschen To: newlib@sourceware.org Subject: Re: [PATCH 08/11] Add stdio atexit handler Message-ID: Reply-To: newlib@sourceware.org Mail-Followup-To: newlib@sourceware.org References: <20220510080927.28839-1-matthew.joyce@embedded-brains.de> <20220510080927.28839-9-matthew.joyce@embedded-brains.de> MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.78 on 10.11.54.6 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=vinschen@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-5.8 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: newlib@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Newlib mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 11 May 2022 16:54:21 -0000 On May 11 17:23, Corinna Vinschen wrote: > On May 10 10:09, Matthew Joyce wrote: > > From: Matt Joyce > > > > Add a dedicated stdio atexit handler to avoid using _GLOBAL_REENT in exit(). > > The idea is ok, I would just prefer to use another name. The reason is > that an unsuspecting user could assume that this function actually gets > added to the atexit functions. What about stdio_exit_handler()? Btw., this produces a build problem in Cygwin: winsup/cygwin/signal.cc:179:1: error: conflicting declaration of C function ‘unsigned int usleep(useconds_t)’ 179 | usleep (useconds_t useconds) | ^~~~~~ In file included from libc/include/unistd.h:4, from winsup/cygwin/../../newlib/libc/stdio/local.h:29, from winsup/cygwin/signal.cc:25: libc/include/sys/unistd.h:240:9: note: previous declaration ‘int usleep(useconds_t)’ 240 | int usleep (useconds_t __useconds); | ^~~~~~ Corinna