From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id D5C1A3857372 for ; Thu, 12 May 2022 08:14:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org D5C1A3857372 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1652343251; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=IUGjzms98/WzuVOfBh4E2lJk+AK/dlxZ265KaLa+zBs=; b=iuY3qFxL8ggbMsy4aR/ySYhxXw4wEZdUu2DsIO4M8xjtFN2AqEimn0y70rsed0N5q6f8QW BBcLzUA7W0XulPeqgn0PPvmhzAlGXYK9z8ncRCaOC0wIUyniYoHKKmadVyQf1K0mkHzClW Q/coYK6Pv4cu3U4+0uOd3FLCeuSSZcc= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-63-z8Wf4BXUNTy98g1BRQOk-Q-1; Thu, 12 May 2022 04:14:10 -0400 X-MC-Unique: z8Wf4BXUNTy98g1BRQOk-Q-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 2A33F803D45 for ; Thu, 12 May 2022 08:14:10 +0000 (UTC) Received: from calimero.vinschen.de (unknown [10.36.112.8]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 064DC40CF8F4 for ; Thu, 12 May 2022 08:14:10 +0000 (UTC) Received: by calimero.vinschen.de (Postfix, from userid 500) id B9BF3A80965; Thu, 12 May 2022 10:14:08 +0200 (CEST) Date: Thu, 12 May 2022 10:14:08 +0200 From: Corinna Vinschen To: newlib@sourceware.org Subject: Re: [PATCH] Cygwin: signal.cc: Include Message-ID: Reply-To: newlib@sourceware.org Mail-Followup-To: newlib@sourceware.org References: <20220512064332.23298-1-sebastian.huber@embedded-brains.de> MIME-Version: 1.0 In-Reply-To: <20220512064332.23298-1-sebastian.huber@embedded-brains.de> X-Scanned-By: MIMEDefang 2.84 on 10.11.54.1 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=vinschen@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Spam-Status: No, score=-11.3 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: newlib@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Newlib mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 12 May 2022 08:14:13 -0000 Hi Sebastian, On May 12 08:43, Sebastian Huber wrote: > Include for sleep() and usleep() declarations. Fix return type of > usleep(). > --- > winsup/cygwin/signal.cc | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/winsup/cygwin/signal.cc b/winsup/cygwin/signal.cc > index 9b6c2509d..22d3715df 100644 > --- a/winsup/cygwin/signal.cc > +++ b/winsup/cygwin/signal.cc > @@ -11,6 +11,7 @@ details. */ > > #include "winsup.h" > #include > +#include > #include > #include > #include "pinfo.h" > @@ -163,7 +164,7 @@ nanosleep (const struct timespec *rqtp, struct timespec *rmtp) > return 0; > } > > -extern "C" unsigned int > +unsigned int Why are you dropping the extern "C" here? It's not really necessary at this point, but all functions in C++ files exported to the userspace are marked this way. > sleep (unsigned int seconds) > { > struct timespec req, rem; > @@ -174,7 +175,7 @@ sleep (unsigned int seconds) > return 0; > } > > -extern "C" unsigned int > +int > usleep (useconds_t useconds) Good catch, otherwise, thank you! I'd prefer if you push just the type change and keep the extern "C" as a marker for exported functions. Thanks, Corinna