From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id AC72B3857372 for ; Thu, 12 May 2022 08:15:46 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org AC72B3857372 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1652343346; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=3h/4yNmzvjEv+Ol5wbF8ztwUMcPBjFoq2Vzel3Ff9jA=; b=P563/zJhHozDGir9p/Dd2gTroRonZR14/dAEy3+MjgcSyVUfOr92XbV/w3zuLIfVCR1rGi 2x28UmsjC0Yn0ayyO0itrUUN+SxUTzJaYOAOb+xVLdnlIP3fPvdOntKc0CFvJzVIRmvSll 9LHLQh8v8TYNAfUbyA9Ykaobn3oyV1I= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-653-xWA1-4QsN52waUcJvZUBTw-1; Thu, 12 May 2022 04:15:45 -0400 X-MC-Unique: xWA1-4QsN52waUcJvZUBTw-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id DECD43C19022 for ; Thu, 12 May 2022 08:15:44 +0000 (UTC) Received: from calimero.vinschen.de (unknown [10.36.112.8]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B97F12026D6A for ; Thu, 12 May 2022 08:15:44 +0000 (UTC) Received: by calimero.vinschen.de (Postfix, from userid 500) id 98B63A80965; Thu, 12 May 2022 10:15:43 +0200 (CEST) Date: Thu, 12 May 2022 10:15:43 +0200 From: Corinna Vinschen To: newlib@sourceware.org Subject: Re: [PATCH v2] Cygwin: syscalls.cc: Include ../stdio/local.h Message-ID: Reply-To: newlib@sourceware.org Mail-Followup-To: newlib@sourceware.org References: <20220512070814.69477-1-sebastian.huber@embedded-brains.de> MIME-Version: 1.0 In-Reply-To: <20220512070814.69477-1-sebastian.huber@embedded-brains.de> X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=vinschen@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Spam-Status: No, score=-5.8 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: newlib@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Newlib mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 12 May 2022 08:15:47 -0000 On May 12 09:08, Sebastian Huber wrote: > Include Newlib internal ../stdio/local.h for the _fwalk_reent() declaration. > Add C++ support to local.h As I wrote in my last reply to patch 9, please don't include internal newlib headers. Let's move these declarations, as far as they are required from Cygwin, to sys/reeent.h or sys/stdio.h, or some other adequate system header. Thanks, Corinna