From: Corinna Vinschen <vinschen@redhat.com>
To: newlib@sourceware.org
Subject: Re: [PATCH] Cygwin: signal.cc: Include <unistd.h>
Date: Thu, 12 May 2022 10:46:33 +0200 [thread overview]
Message-ID: <YnzJaQLNgsLVKFRX@calimero.vinschen.de> (raw)
In-Reply-To: <b426d8b9-9e5b-29a2-d9f8-6d811fbb82aa@embedded-brains.de>
On May 12 10:22, Sebastian Huber wrote:
> On 12/05/2022 10:14, Corinna Vinschen wrote:
> > > sleep (unsigned int seconds)
> > > {
> > > struct timespec req, rem;
> > > @@ -174,7 +175,7 @@ sleep (unsigned int seconds)
> > > return 0;
> > > }
> > > -extern "C" unsigned int
> > > +int
> > > usleep (useconds_t useconds)
> > Good catch, otherwise, thank you! I'd prefer if you push just the
> > type change and keep the extern "C" as a marker for exported functions.
>
> Ok, what about the unistd.h include?
Let's keep it. It might help to uncover other issues in future.
Thx,
Corinna
next prev parent reply other threads:[~2022-05-12 8:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-12 6:43 Sebastian Huber
2022-05-12 8:14 ` Corinna Vinschen
2022-05-12 8:22 ` Sebastian Huber
2022-05-12 8:46 ` Corinna Vinschen [this message]
2022-05-12 14:48 ` Brian Inglis
2022-05-12 16:05 ` Corinna Vinschen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YnzJaQLNgsLVKFRX@calimero.vinschen.de \
--to=vinschen@redhat.com \
--cc=newlib@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).