From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 964643857364 for ; Mon, 16 May 2022 11:09:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 964643857364 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1652699360; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=I+IlRXT+J6+aF+ku/Uw2vD02BRVIOHtJgB8w3S3pO9s=; b=UfGyNgcX20Pf7uot68uvLNJRxY8c/w6IzLhWgJDozdqAeR6xplC5fhyEmrVaX0Lve6wLWK FE9rwDhLt9giYi3E6J+AySu6jTKPxy+feXXvORDMm0F9IalBk7NGJmWlkerHvOEJdJrsqQ FOOcDn2XIEDlqC3ZfWjn6+ClBW6a5wQ= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-121-oxTMeNd9OYy6l7LHC5cE8w-1; Mon, 16 May 2022 07:09:19 -0400 X-MC-Unique: oxTMeNd9OYy6l7LHC5cE8w-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id C4C35805B25 for ; Mon, 16 May 2022 11:09:18 +0000 (UTC) Received: from calimero.vinschen.de (unknown [10.36.112.11]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A0A7740D1B98 for ; Mon, 16 May 2022 11:09:18 +0000 (UTC) Received: by calimero.vinschen.de (Postfix, from userid 500) id D366AA80885; Mon, 16 May 2022 13:09:16 +0200 (CEST) Date: Mon, 16 May 2022 13:09:16 +0200 From: Corinna Vinschen To: newlib@sourceware.org Subject: Re: [PATCH 2/7] Cygwin: Enable backward binary compatibility Message-ID: Reply-To: newlib@sourceware.org Mail-Followup-To: newlib@sourceware.org References: <20220513134700.68563-1-sebastian.huber@embedded-brains.de> <20220513134700.68563-3-sebastian.huber@embedded-brains.de> <69617006-7222-3141-54aa-d3eff3031a1f@embedded-brains.de> MIME-Version: 1.0 In-Reply-To: <69617006-7222-3141-54aa-d3eff3031a1f@embedded-brains.de> X-Scanned-By: MIMEDefang 2.84 on 10.11.54.2 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=vinschen@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Spam-Status: No, score=-11.1 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: newlib@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Newlib mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 May 2022 11:09:22 -0000 On May 16 07:31, Sebastian Huber wrote: > On 13/05/2022 22:15, Corinna Vinschen wrote: > > On May 13 15:46, Sebastian Huber wrote: > > > --- > > > winsup/cygwin/include/cygwin/config.h | 1 + > > > 1 file changed, 1 insertion(+) > > > > > > diff --git a/winsup/cygwin/include/cygwin/config.h b/winsup/cygwin/include/cygwin/config.h > > > index 71a216fbd..2d410a2e7 100644 > > > --- a/winsup/cygwin/include/cygwin/config.h > > > +++ b/winsup/cygwin/include/cygwin/config.h > > > @@ -80,6 +80,7 @@ extern inline struct _reent *__getreent (void) > > > #define __TM_GMTOFF tm_gmtoff > > > #define __TM_ZONE tm_zone > > > #define _USE_LONG_TIME_T 1 > > > +#define _NEWLIB_BACKWARD_BINARY_COMPAT 1 > > Why? > > > > AFAICS we don't expose _REENT to user space. In theory (knocking > > on wood here), we shouldn't need _REENT binary compat. > > Ok good, I always thought the unused members in struct _reent were mainly > for Cygwin. Sorry, my bad. I wasn't thinking straight last week, apparently. While Cygwin doesn't directly expose the functions taking a reent ptr as parameter, we have to expose some of them indirectly, because they are used in the stdio macros and inline functions, for instance, __swbuf_r. So, yeah, Cygwin actually needs _reent backward compat here. > Maybe the option should be named --enable-newlib-reent-binary-compat and > restricted to struct _reent. That would be great. Does the above require a v3 of your patch set? Thanks, Corinna