Re: [PATCH 1/6] Add --enable-newlib-reent-binary-compat

[Corinna Vinschen <vinschen@redhat.com>]

On May 16 08:55, Sebastian Huber wrote:
> Add the --enable-newlib-reent-binary-compat configure option.  This option is
> disabled by default.  If enabled, then unused members in struct _reent are
> preserved to maintain the structure layout.

Given these members are unused, we can reuse them for other purposes.
The only interesting thing is to keep the existing and still used
members in the same offset.  Along these lines, wouldn't it
be great for potential future stuff we would like to add
to _reent, if we take the chance and rename the unused members to

   int _reserved1;
   [...]
   int _reserved2[2];

etc.?  The latter array style would be possible, for instance, with
_unused_sdidinit and _unspecified_locale_info, because they happen to
clump together. The old comments describeing what has been at one
point, could go away, and the layout may become just this teeny little
bit cleaner...

What do you think?


Thanks,
Corinna