From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 07F8A3858D3C for ; Tue, 17 May 2022 12:49:09 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 07F8A3858D3C Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1652791748; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=vHTuGqpwocqtllHGOQSyH7Y1MJArstWJq67/z+4dB7Y=; b=bsj1eTASf3qMK3NgBZsA7OYlwB+v/fecl9OLGPl+gFig9zjKvkTIJi/sPzaexXzYIPf/oA ZInB1pduH4l4qwuAloSmUqNY0bTD5IxujNqXTF/GPGARngvxZInR2/8ldt33tteJQrfn9n WbwQPQq3Fjb1Ho/pQU3QZXAwe+7ASl4= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-350-1iCSV_d3N82zZIuZDVFsDg-1; Tue, 17 May 2022 08:49:07 -0400 X-MC-Unique: 1iCSV_d3N82zZIuZDVFsDg-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 5A8728219B2 for ; Tue, 17 May 2022 12:49:07 +0000 (UTC) Received: from calimero.vinschen.de (unknown [10.36.112.7]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 3501540C1421 for ; Tue, 17 May 2022 12:49:07 +0000 (UTC) Received: by calimero.vinschen.de (Postfix, from userid 500) id EF546A80971; Tue, 17 May 2022 14:49:05 +0200 (CEST) Date: Tue, 17 May 2022 14:49:05 +0200 From: Corinna Vinschen To: newlib@sourceware.org Subject: Re: [PATCH v3 6/7] Optional struct _reent::_new::_unused Message-ID: Reply-To: newlib@sourceware.org Mail-Followup-To: newlib@sourceware.org References: <20220516155329.29458-1-sebastian.huber@embedded-brains.de> <20220516155329.29458-7-sebastian.huber@embedded-brains.de> MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.84 on 10.11.54.2 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=vinschen@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Spam-Status: No, score=-11.1 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: newlib@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Newlib mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 May 2022 12:49:10 -0000 On May 16 17:58, Sebastian Huber wrote: > > > On 16/05/2022 17:53, Sebastian Huber wrote: > > diff --git a/newlib/libc/include/sys/reent.h b/newlib/libc/include/sys/reent.h > > index 6d6796ed3..4b09e8cd5 100644 > > --- a/newlib/libc/include/sys/reent.h > > +++ b/newlib/libc/include/sys/reent.h > > @@ -685,6 +685,7 @@ struct _reent > > _mbstate_t _wcsrtombs_state; > > int _h_errno; > > } _reent; > > +#ifdef _REENT_BACKWARD_BINARY_COMPAT > > /* Two next two fields were once used by malloc. They are no longer > > used. They are used to preserve the space used before so as to > > allow addition of new reent fields and keep binary compatibility. */ > > I guess the comment could be also removed. Yes. > > > @@ -693,7 +694,8 @@ struct _reent > > #define _N_LISTS 30 > > unsigned char * _nextf[_N_LISTS]; > > unsigned int _nmalloc[_N_LISTS]; > > Maybe we should also rename _nextf in _reserved_4 and _nmalloc in > _reserved_5. Right, that would be great. Feel free to push the patch with this change. Thanks, Corinna