From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id CD64E3858C51 for ; Tue, 17 May 2022 19:33:56 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org CD64E3858C51 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1652816036; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=CTaS0JqPYiiqAivja4wGBq91euN+a95oS3SV1yveVTo=; b=OMswEsHB16Ro3OPCc2AsQQIp/vuQpimwFDlmhx/JcmRacUGVeqp3k6Kyw5XvjKNkMQGccB /z4JtAiK6toGzpKHxJN4DWu8PWrg66mudgaGucvOyHRkLbsbGdTBmoZbp0ItTfX4JRHG1B abptokcL3MQbaIL67ccPhucaKRPDxq0= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-383-klLHW2wZP1KdPV8SgfsJ4g-1; Tue, 17 May 2022 15:33:55 -0400 X-MC-Unique: klLHW2wZP1KdPV8SgfsJ4g-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 265431C0CE6D for ; Tue, 17 May 2022 19:33:55 +0000 (UTC) Received: from calimero.vinschen.de (unknown [10.36.112.7]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 03194400E115 for ; Tue, 17 May 2022 19:33:55 +0000 (UTC) Received: by calimero.vinschen.de (Postfix, from userid 500) id E6D6CA8065D; Tue, 17 May 2022 21:33:53 +0200 (CEST) Date: Tue, 17 May 2022 21:33:53 +0200 From: Corinna Vinschen To: newlib@sourceware.org Subject: Re: [PATCH] Use right lock release in __register_exitproc() Message-ID: Reply-To: newlib@sourceware.org Mail-Followup-To: newlib@sourceware.org References: <20220517170438.122400-1-sebastian.huber@embedded-brains.de> MIME-Version: 1.0 In-Reply-To: <20220517170438.122400-1-sebastian.huber@embedded-brains.de> X-Scanned-By: MIMEDefang 2.84 on 10.11.54.2 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=vinschen@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Spam-Status: No, score=-11.6 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: newlib@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Newlib mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 May 2022 19:33:57 -0000 On May 17 19:04, Sebastian Huber wrote: > --- > newlib/libc/stdlib/__atexit.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/newlib/libc/stdlib/__atexit.c b/newlib/libc/stdlib/__atexit.c > index 04bdf194e..e59f04c2e 100644 > --- a/newlib/libc/stdlib/__atexit.c > +++ b/newlib/libc/stdlib/__atexit.c > @@ -128,7 +128,7 @@ __register_exitproc (int type, > if (args == NULL) > { > #ifndef __SINGLE_THREAD__ > - __lock_release(__atexit_recursive_mutex); > + __lock_release_recursive(__atexit_recursive_mutex); > #endif > return -1; > } > -- > 2.35.3 Yeah, that looks wrong to me, either. Fortunately it had no negative impact on Cygwin. Thanks for catching, please push. Corinna