[PATCH] newlib: libc: reente.h: remove unnecessary parentheses

[PATCH] newlib: libc: reente.h: remove unnecessary parentheses

[jiawei]

From: Jia-Wei Chen <jiawei@iscas.ac.cn>

The compiler warns the double parentheses are unnecessary in some
target, and cause fail cases when doing some testcases in regression.

gcc/testsuite/g++.dg/warn/Wstringop-overflow-6.C

Remove the unnecessary parentheses will fix it. See more details in 
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=85775

Same like in commit 05425831290c9869bc7987b5df3ce84aa4f19a6c,
Author: Maxim Blinov <maxim.blinov@embecosm.com>
Date:   Thu Jul 22 22:41:42 2021 +0100

     Remove unneccesary parenthesis around declarator

Thanks for Sebastian Huber's remind!

ChangeLog:

        * newlib/libc/include/sys/reent.h (struct _reent): Remove
        * additonal parentheses. 

---
 newlib/libc/include/sys/reent.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/newlib/libc/include/sys/reent.h b/newlib/libc/include/sys/reent.h
index 4a3cfbd34..64d76c27c 100644
--- a/newlib/libc/include/sys/reent.h
+++ b/newlib/libc/include/sys/reent.h
@@ -421,7 +421,7 @@ struct _reent
   char *_asctime_buf;
 
   /* signal info */
-  void (**(_sig_func))(int);
+  void (** _sig_func)(int);
 
 #ifdef _REENT_BACKWARD_BINARY_COMPAT
   struct _atexit *_reserved_6;
-- 
2.25.1

Re: [PATCH] newlib: libc: reente.h: remove unnecessary parentheses

[Corinna Vinschen]

On May 18 18:03, jiawei wrote:
> From: Jia-Wei Chen <jiawei@iscas.ac.cn>
> 
> The compiler warns the double parentheses are unnecessary in some
> target, and cause fail cases when doing some testcases in regression.
> 
> gcc/testsuite/g++.dg/warn/Wstringop-overflow-6.C
> 
> Remove the unnecessary parentheses will fix it. See more details in 
> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=85775
> 
> Same like in commit 05425831290c9869bc7987b5df3ce84aa4f19a6c,
> Author: Maxim Blinov <maxim.blinov@embecosm.com>
> Date:   Thu Jul 22 22:41:42 2021 +0100
> 
>      Remove unneccesary parenthesis around declarator
> 
> Thanks for Sebastian Huber's remind!
> 
> ChangeLog:
> 
>         * newlib/libc/include/sys/reent.h (struct _reent): Remove
>         * additonal parentheses. 

Pushed with fixed subject and dropping tne CVS-style entry in the commit
message. We don't do CVS anymore these days :)


Thanks,
Corinna