From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 119BB3858016 for ; Wed, 18 May 2022 10:39:31 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 119BB3858016 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1652870370; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=zcSPDoOLRYNeUEdAo4T3VLWwW0AjMS3vSv7F01B/o+o=; b=ZWSOiHo3kgUpr6RdCk6hcHdjJGxgbGXG2+RmtAwMl5y3mf/4H8uWKZHiQUYEUCEHfMXZTe nRAJ69LRKarIvRM7dIRdsxs5nRyyYRZzaKBJ0tnB49ryt8SeAa57tu/Z08LhyTx/hRxh59 Rv15CNhdq/g1KFlxbC06oqmLc5U6+84= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-658-7nvFDH81NjylHWI8yYcqrA-1; Wed, 18 May 2022 06:39:27 -0400 X-MC-Unique: 7nvFDH81NjylHWI8yYcqrA-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 2860C29DD9AB; Wed, 18 May 2022 10:39:27 +0000 (UTC) Received: from calimero.vinschen.de (unknown [10.36.112.7]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B845A7C4E; Wed, 18 May 2022 10:39:24 +0000 (UTC) Received: by calimero.vinschen.de (Postfix, from userid 500) id 75F99A80874; Wed, 18 May 2022 12:39:23 +0200 (CEST) Date: Wed, 18 May 2022 12:39:23 +0200 From: Corinna Vinschen To: jiawei Cc: newlib@sourceware.org, maxim.blinov@embecosm.com, msebor@redhat.com, wuwei2016@iscas.ac.cn, palmer@dabbelt.com, kito.cheng@sifive.com Subject: Re: [PATCH] newlib: libc: reente.h: remove unnecessary parentheses Message-ID: Reply-To: newlib@sourceware.org Mail-Followup-To: jiawei , newlib@sourceware.org, maxim.blinov@embecosm.com, msebor@redhat.com, wuwei2016@iscas.ac.cn, palmer@dabbelt.com, kito.cheng@sifive.com References: <20220518100318.890201-1-jiawei@iscas.ac.cn> MIME-Version: 1.0 In-Reply-To: <20220518100318.890201-1-jiawei@iscas.ac.cn> X-Scanned-By: MIMEDefang 2.79 on 10.11.54.5 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=vinschen@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Spam-Status: No, score=-5.7 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, KAM_SHORT, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: newlib@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Newlib mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 May 2022 10:39:32 -0000 On May 18 18:03, jiawei wrote: > From: Jia-Wei Chen > > The compiler warns the double parentheses are unnecessary in some > target, and cause fail cases when doing some testcases in regression. > > gcc/testsuite/g++.dg/warn/Wstringop-overflow-6.C > > Remove the unnecessary parentheses will fix it. See more details in > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=85775 > > Same like in commit 05425831290c9869bc7987b5df3ce84aa4f19a6c, > Author: Maxim Blinov > Date: Thu Jul 22 22:41:42 2021 +0100 > > Remove unneccesary parenthesis around declarator > > Thanks for Sebastian Huber's remind! > > ChangeLog: > > * newlib/libc/include/sys/reent.h (struct _reent): Remove > * additonal parentheses. Pushed with fixed subject and dropping tne CVS-style entry in the commit message. We don't do CVS anymore these days :) Thanks, Corinna