From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 8EAA8383A374 for ; Wed, 13 Jul 2022 11:13:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 8EAA8383A374 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1657710805; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=4WgOK9T17HADkAB9AMtvznKvMOvoLem4XG3ubBDagL8=; b=YyoEbqfhne/4QrJ2II6lb7TG4wftLi6MEn6rAudn4H3V3ep9bEDeCox76UPqYh5uTAYEhV XKDvwBNNxG2nTwkcqbxfSpEeAXFezH2lhtE+uqYJBRjq73xlv/QPw4rRRb/cfqMdouylyT uPoFFM0HLJU+KKjIYbay/gZkpQUZYlY= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-488-WmP3K3c9PY-rrYJscPe_uA-1; Wed, 13 Jul 2022 07:13:24 -0400 X-MC-Unique: WmP3K3c9PY-rrYJscPe_uA-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id DDE721C01B2C for ; Wed, 13 Jul 2022 11:13:23 +0000 (UTC) Received: from calimero.vinschen.de (unknown [10.39.193.50]) by smtp.corp.redhat.com (Postfix) with ESMTPS id BAE092166B26 for ; Wed, 13 Jul 2022 11:13:23 +0000 (UTC) Received: by calimero.vinschen.de (Postfix, from userid 500) id 33C02A80896; Wed, 13 Jul 2022 13:13:22 +0200 (CEST) Date: Wed, 13 Jul 2022 13:13:22 +0200 From: Corinna Vinschen To: newlib@sourceware.org Subject: Re: Fw: [PATCH 03/14] Add _REENT_ERRNO(ptr) Message-ID: Reply-To: newlib@sourceware.org Mail-Followup-To: newlib@sourceware.org References: <20220621124931.36450-4-sebastian.huber@embedded-brains.de> <29672b0c-34bf-6015-ea8d-9fb8c3c09f2e@embedded-brains.de> <82b5a844-34b6-c983-fac8-a0b9a48ebc40@embedded-brains.de> MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.78 on 10.11.54.6 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=vinschen@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Spam-Status: No, score=-5.7 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: newlib@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Newlib mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 Jul 2022 11:13:26 -0000 On Jul 13 10:19, Sebastian Huber wrote: > On 13/07/2022 09:50, Corinna Vinschen wrote: > > On Jul 13 09:17, Sebastian Huber wrote: > > > On 12/07/2022 20:25, Corinna Vinschen wrote: > > > > > What about renaming the existing __errno_r() uses in Newlib to > > > > > _REENT_ERRNO() with a definition of __errno_r() in for > > > > > potential users outside of Newlib? > > > > Sounds good to me. > > > Attached is a new version of this patch. In this patch the uses of > > > __errno_r() were replaced with _REENT_ERRNO(). > > In future, would you mind to send followup patches as v2, v3, the same > > way as the first patch, please? It's not required as such, but it makes > > applying a series easier. > > Ok, sorry. > > > > > Having said that, the patchset looks good to me. AFAICS this also > > uncovered a minor bug in Cygwin in the errno handling, but that's > > something for us Cygwin folks to patch after you applied your set. > > Thanks for the review, I checked it in. Thanks. To close this, the alleged bug in Cygwin's errno handling isn't a bug, just a misunderstanding on my side. Corinna