public inbox for newlib@sourceware.org
 help / color / mirror / Atom feed
From: Corinna Vinschen <vinschen@redhat.com>
To: newlib@sourceware.org
Subject: Re: [PATCH newlib v1 0/4] Add FreeBSD long double functions
Date: Wed, 24 Aug 2022 11:26:42 +0200	[thread overview]
Message-ID: <YwXu0iVmbD8RfnfZ@calimero.vinschen.de> (raw)
In-Reply-To: <20220822225022.32209-1-joel@rtems.org>

On Aug 22 17:50, Joel Sherrill wrote:
> Hi
> 
> To be clear, this is a V1 for review. It actually does **NOT**
> add every long double math method from FreeBSD. That would add
> unnecessary bulk to this patch set at this point.
> 
> The FreeBSD long double code requires there to be an architecture
> specific _fpmath.h file. This is only available for a handful of
> architestures. Further, LDBL does EQ DBL on many architectures. 
> The FreeBSD long double code will **NOT** compile if there isn't 
> an _fpmath.h file. Thus, the overall approach is:
> 
>   if architecture has _fpmath.h
>      use FreeBSD long double code in libm/common/ldbl
>   else
>      use existing long double code

Erm... Did you actually read my last reply?  We should really not add YA
code path.  Merging the FreeBSD long double functions should work for
basically all supported arches.  We only have to create our own
_fpmath.h supporting all arches based on LDBL_MANT_DIG, isn't it?


Corinna


  parent reply	other threads:[~2022-08-24  9:26 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-22 22:50 Joel Sherrill
2022-08-22 22:50 ` [PATCH newlib v1 1/4] Add infrastructure for incorporating FreeBSD long double methods Joel Sherrill
2022-08-22 22:50 ` [PATCH newlib v1 2/4] Makefile.in and configure: Regenerated Joel Sherrill
2022-08-22 22:50 ` [PATCH newlib v1 3/4] Split libm/common/frexpl.c into LDBL_EQ_DBL and long double versions Joel Sherrill
2022-08-22 22:50 ` [PATCH newlib v1 4/4] Makefile.in: Regenerated Joel Sherrill
2022-08-24  9:26 ` Corinna Vinschen [this message]
2022-08-24 13:40   ` [PATCH newlib v1 0/4] Add FreeBSD long double functions Joel Sherrill
2022-08-26 15:05     ` Corinna Vinschen
2022-08-26 15:45       ` Joel Sherrill
2022-08-26 17:45         ` Corinna Vinschen
2022-08-26 20:45           ` Jeff Johnston

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YwXu0iVmbD8RfnfZ@calimero.vinschen.de \
    --to=vinschen@redhat.com \
    --cc=newlib@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).