From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id CFCF23858430 for ; Wed, 24 Aug 2022 09:26:45 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org CFCF23858430 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1661333205; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=Phvqru1VUdtVaZ36GvlfnhX1Jd9b4TF7YYmNH5z4a10=; b=fLJMNzwVxefF5CoL7YTMI8mjGLabk91OX6kQRRYli0S9Nnb7MUvoB3dolxYKgPRlY2QfSh +wx0o7YyCLjw3sp8DBHd3JkuoXGIDsgvhzdudE1HBF+Ghg4uHm6pr/H6x/ylkGuMb3hI6i twXrs4UdZUl6azlXvKT6QQuwUVpfhts= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-235-V6vREJ8ZMBq4Pq-zf-W6bA-1; Wed, 24 Aug 2022 05:26:44 -0400 X-MC-Unique: V6vREJ8ZMBq4Pq-zf-W6bA-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 1810F38164CE for ; Wed, 24 Aug 2022 09:26:44 +0000 (UTC) Received: from calimero.vinschen.de (unknown [10.39.193.176]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E95772026D4C for ; Wed, 24 Aug 2022 09:26:43 +0000 (UTC) Received: by calimero.vinschen.de (Postfix, from userid 500) id 8E5F9A8088B; Wed, 24 Aug 2022 11:26:42 +0200 (CEST) Date: Wed, 24 Aug 2022 11:26:42 +0200 From: Corinna Vinschen To: newlib@sourceware.org Subject: Re: [PATCH newlib v1 0/4] Add FreeBSD long double functions Message-ID: Reply-To: newlib@sourceware.org Mail-Followup-To: newlib@sourceware.org References: <20220822225022.32209-1-joel@rtems.org> MIME-Version: 1.0 In-Reply-To: <20220822225022.32209-1-joel@rtems.org> X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Spam-Status: No, score=-5.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Aug 22 17:50, Joel Sherrill wrote: > Hi > > To be clear, this is a V1 for review. It actually does **NOT** > add every long double math method from FreeBSD. That would add > unnecessary bulk to this patch set at this point. > > The FreeBSD long double code requires there to be an architecture > specific _fpmath.h file. This is only available for a handful of > architestures. Further, LDBL does EQ DBL on many architectures. > The FreeBSD long double code will **NOT** compile if there isn't > an _fpmath.h file. Thus, the overall approach is: > > if architecture has _fpmath.h > use FreeBSD long double code in libm/common/ldbl > else > use existing long double code Erm... Did you actually read my last reply? We should really not add YA code path. Merging the FreeBSD long double functions should work for basically all supported arches. We only have to create our own _fpmath.h supporting all arches based on LDBL_MANT_DIG, isn't it? Corinna