From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id CB9943858C50 for ; Wed, 5 Apr 2023 09:23:46 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org CB9943858C50 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1680686626; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=LJ8dVo1kGSmh90hBI887yRUvXRxdBhOsAGzoswYUHK0=; b=IBX2c6EHQ1EZJAxH7aVcNXA4CVxBn1Ivq5GS8xeT4o+vfOxHpKIZmSCPPuxRYgJ3Kt+IJM CfF0xmI5I7tG6D6YTxtQNIh8dWs6aWLjYLixK0ALVvF23qIEBfX+bbwUwfdDvUwGO++HNy llNJfWrltF588/HaZHyc6N/b6ivzPe4= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-274-23OAbFcAMyqbHTwwhM9-4g-1; Wed, 05 Apr 2023 05:23:43 -0400 X-MC-Unique: 23OAbFcAMyqbHTwwhM9-4g-1 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id C930B3823A07; Wed, 5 Apr 2023 09:23:42 +0000 (UTC) Received: from calimero.vinschen.de (unknown [10.39.193.63]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A6E87492C14; Wed, 5 Apr 2023 09:23:42 +0000 (UTC) Received: by calimero.vinschen.de (Postfix, from userid 500) id 3D9ACA80C9F; Wed, 5 Apr 2023 11:23:41 +0200 (CEST) Date: Wed, 5 Apr 2023 11:23:41 +0200 From: Corinna Vinschen To: Jennifer Averett Cc: newlib@sourceware.org Subject: Re: [PATCH 0/3]: Add math support for non LDBL_EQ_DBL architecture Message-ID: Reply-To: newlib@sourceware.org Mail-Followup-To: Jennifer Averett , newlib@sourceware.org References: <20230403205837.1595602-1-jennifer.averett@oarcorp.com> MIME-Version: 1.0 In-Reply-To: <20230403205837.1595602-1-jennifer.averett@oarcorp.com> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.9 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Spam-Status: No, score=-5.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Jennifer, On Apr 3 15:58, Jennifer Averett wrote: > The attached set of patches add long double support for i386, aarch64 and > x86_64. The riscv and powerpc are supported by FreeBSD but will need more > work to be supported by newlib. FreeBSD has separate 64 and 32 bit powerpc > support which would have to be integrated for newlib. FreeBSD riscv support > is 64 and there are issues with fenv.h that would have to be addressed. Thanks for your patchset, it looks pretty well to me, though I like to have input on this from my co-maintainer Jeff, too. I noticed that you exclude Cygwin from the new code, which makes sense as long as we provide our own long double math taken from Mingw-w64. However, there's something not quite right. When trying to build I get symbol conflicts for the fdim{f,l} and scalbln{f,l} symbols in the link stage (paths shortend for readability): ld: libm.a(libm_a-s_fdim.o): in function `fdimf': newlib/libm/ld/s_fdim.c:47: multiple definition of `fdimf'; libm.a(libm_a-sf_fdim.o):newlib/libm/common/sf_fdim.c:16: first defined here ld: libm.a(libm_a-s_fdim.o): in function `fdiml': newlib/libm/ld/s_fdim.c:48: multiple definition of `fdiml'; libdll.a(fdiml.o):winsup/cygwin/math/fdiml.c:11: first defined here ld: libm.a(libm_a-s_scalbln.o): in function `scalblnf': newlib/libm/ld/s_scalbln.c:46: multiple definition of `scalblnf'; libm.a(libm_a-sf_scalbln.o):newlib/libm/common/sf_scalbln.c:34: first defined here ld: libm.a(libm_a-s_scalbln.o): in function `scalblnl': newlib/libm/ld/s_scalbln.c:53: multiple definition of `scalblnl'; libdll.a(scalbnl.o):winsup/cygwin/scalbnl.S:19: first defined here The conflicts really ony occur for these four functions. Any chance to fix these? Thanks, Corinna