From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id C1D7B3858D32 for ; Thu, 6 Apr 2023 09:00:47 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C1D7B3858D32 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1680771647; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=byqG1QR0QhXB85981ChmRQQ9967rD7am3Cs4g3bmN7o=; b=cKCc5MhpzcihtvFbCugLrR+GMlRL9aMOPcWAX6cgyqZLfb4Bq8TolNzpCzSlfGxwpoNFOg ZFrWc9XhmihjX61y3xkQA13ndpeKGgb/JEQ1H6c9cfYYdWhWFGh6YeX886OtphPArQjB+c Jl9hvx9NWUUtb5s6kmysUm6uaMU+jgg= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-453-z1VE1o2TMVGZXX_qILneRA-1; Thu, 06 Apr 2023 05:00:44 -0400 X-MC-Unique: z1VE1o2TMVGZXX_qILneRA-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id CDF9C855304; Thu, 6 Apr 2023 09:00:43 +0000 (UTC) Received: from calimero.vinschen.de (unknown [10.39.193.63]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A2B0E141511D; Thu, 6 Apr 2023 09:00:43 +0000 (UTC) Received: by calimero.vinschen.de (Postfix, from userid 500) id 3F70AA80C68; Thu, 6 Apr 2023 11:00:42 +0200 (CEST) Date: Thu, 6 Apr 2023 11:00:42 +0200 From: Corinna Vinschen To: Joel Sherrill Cc: newlib@sourceware.org, Jennifer Averett Subject: Re: [PATCH 0/3]: Add math support for non LDBL_EQ_DBL architecture Message-ID: Reply-To: newlib@sourceware.org Mail-Followup-To: Joel Sherrill , newlib@sourceware.org, Jennifer Averett References: <20230403205837.1595602-1-jennifer.averett@oarcorp.com> MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 3.1 on 10.11.54.7 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-4.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Apr 5 10:44, Joel Sherrill wrote: > On Wed, Apr 5, 2023 at 4:23 AM Corinna Vinschen wrote: > > I noticed that you exclude Cygwin from the new code, which makes sense > > as long as we provide our own long double math taken from Mingw-w64. > > What needs to happen for Cygwin/Mingw_w64? Honestly, we didn't discuss > that at all. Not sure I understand the question. After the patch, Cygwin should just still work. Mingw-w64 isn't supported by newlib. What do you mean? > > However, there's something not quite right. When trying to build I get > > symbol conflicts for the fdim{f,l} and scalbln{f,l} symbols in the link > > stage (paths shortend for readability): > > [...] > > We chatted and those will be fixed in the next round. Thanks. > Anything else you think needs tidying up? Well, yes. The patch introduces a new header . Cygwin already maintains an header, as on Linux. The way we install header files is that first, the newlib headers are installed, and then, second, Cygwin headers are installed, thus overriding newlib headers with Cygwin headers as required. We have to maintain for userspace compatibility, but after the installation user will find two different versions of endian.h, one in /usr/include, one in /usr/include/sys. Would it make a lot of problems to move to ? Thanks, Corinna