From: Corinna Vinschen <vinschen@redhat.com>
To: newlib@sourceware.org
Subject: Re: Placement of signgam in libc instead of libm
Date: Mon, 24 Apr 2023 10:52:02 +0200 [thread overview]
Message-ID: <ZEZDMh+CsexcZqbB@calimero.vinschen.de> (raw)
In-Reply-To: <CAF9ehCVAgnervApUPXk9gwwaz1FJ3666+qz-E-=fBxj5LurkGw@mail.gmail.com>
On Apr 20 16:20, Joel Sherrill wrote:
> Hi
>
> While double some checking that all references used by the long double math
> routines Jennifer are resolved when linking, we have found a small oddity.
>
> The file libc/reent/signgam.c is implemented as follows:
>
> int *
> __signgam (void)
> {
> return &_REENT_SIGNGAM(_REENT);
> }
>
> When TLS is enabled, the macro _REENT_SIGNGAM resolves to
> _tls_gamma_signgam which is in the file libm/math/w_lgamma.c. This creates
> the first reference from libc to libm that I have ever seen and requires
> explicitly linking with -lm -lc when using lgamma().
>
> Would anyone be opposed to moving this method to libm/math?
Not me, but Jeff added this to libc for a reason, I guess...?
Corinna
next prev parent reply other threads:[~2023-04-24 8:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-20 21:20 Joel Sherrill
2023-04-24 8:52 ` Corinna Vinschen [this message]
2023-04-24 15:16 ` Jeff Johnston
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZEZDMh+CsexcZqbB@calimero.vinschen.de \
--to=vinschen@redhat.com \
--cc=newlib@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).