On 12 Sep 2023 20:54, Hans-Bernhard Bröker wrote:
> Am 11.09.2023 um 09:12 schrieb Sebastian Huber:
> > Hello,
> > 
> > when I run "autoreconf" in "newlib", I get the following local changes:
> [...]
> > Are these changes due to a local configuration or tooling issue or 
> > should we check in these changes?
> 
> You almost certainly should not check in those changes.  In fact, you 
> probably have to revert to the checked-in copy, or remove those changes 
> manually.
> 
> They result from the very unusual way newlib handles configuration 
> headers.  You'll find that those 4 elements are instead defined in the 
> _other_ checked-in *.hin file: _newlib_version.hin.  We artificially 
> split the autoheader definitions into these two separate files, and then 
> #include the configure-generated _newlib_version.h into the generated 
> newlib.h.
> 
> Unfortunately autoreconf does not really understand this rather 
> convoluted scheme. While it allows for more than one call to 
> AC_CONFIG_HEADER, to configure more than one *.hin file, it does not 
> recognize the idea that autoheader should put any less than all of the 
> AC_DEFINE()d entries into its output file (newlib.hin).
> 
> So this needs some extra, manual post-processing after running 
> autoreconf, to remove the duplicate definitions.

we already process newlib.h when generating it in configure to filter out
some content.  we could easily add these specific defines to the filter
to avoid confusion/mistakes during autoreconf.  i'll send a patch.
-mike