From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.gentoo.org (mail.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) by sourceware.org (Postfix) with ESMTP id 5BB573858CD1 for ; Sun, 15 Oct 2023 09:21:56 +0000 (GMT) ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 5BB573858CD1 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2001:470:ea4a:1:5054:ff:fec7:86e4 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1697361717; cv=none; b=SGHagEbnsOpOyShppy5sckrNOIwawKCww/rj/W1wvpGvzAK7c6FEyyBoDzEJzQzAtbOrj8+vemOmUlkBrXjwz8wZNv6gU2mTye21bVjH9DP/rvLNIiwZfSvPFt0yCzeCx5cQKSjW4BGI4D3ncCAfSEzDg5Ar01yXiiw4bniH90g= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1697361717; c=relaxed/simple; bh=kOUXMDEmXHqbVYj5NJ9/l4WXsoslr9zB6ALEjkTRpng=; h=Date:From:To:Subject:Message-ID:MIME-Version; b=eFmn9ZAxI/72HH4CCWK7Bs+1MB87nzp6o2VqJa12gZHDIAOa9A4ENNSbol4r/UIPKqEF8obdGIoU/h0AKRRZOzLqo/yoR1dML174x/+zUiQNoVd/57hZSRtI7C9Npno0ckORyT/SLIRDXiI0S3NBqeySo2boPxejSOdPZ6s7Lto= ARC-Authentication-Results: i=1; server2.sourceware.org DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 5BB573858CD1 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gentoo.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gentoo.org Received: by smtp.gentoo.org (Postfix, from userid 559) id EA9C1335CEE; Sun, 15 Oct 2023 09:21:55 +0000 (UTC) Date: Sun, 15 Oct 2023 15:06:54 +0545 From: Mike Frysinger To: Hans-Bernhard =?utf-8?Q?Br=C3=B6ker?= Cc: Sebastian Huber , newlib Subject: Re: Regenerate newlib/newlib.hin? Message-ID: References: <687108d5-4350-4833-8bd4-2e3ff458c498@embedded-brains.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="YqQUpTzWUgDU2dTO" Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-5.1 required=5.0 tests=BAYES_00,JMQ_SPF_NEUTRAL,KAM_DMARC_STATUS,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --YqQUpTzWUgDU2dTO Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 12 Sep 2023 20:54, Hans-Bernhard Br=C3=B6ker wrote: > Am 11.09.2023 um 09:12 schrieb Sebastian Huber: > > Hello, > >=20 > > when I run "autoreconf" in "newlib", I get the following local changes: > [...] > > Are these changes due to a local configuration or tooling issue or=20 > > should we check in these changes? >=20 > You almost certainly should not check in those changes. In fact, you=20 > probably have to revert to the checked-in copy, or remove those changes= =20 > manually. >=20 > They result from the very unusual way newlib handles configuration=20 > headers. You'll find that those 4 elements are instead defined in the=20 > _other_ checked-in *.hin file: _newlib_version.hin. We artificially=20 > split the autoheader definitions into these two separate files, and then= =20 > #include the configure-generated _newlib_version.h into the generated=20 > newlib.h. >=20 > Unfortunately autoreconf does not really understand this rather=20 > convoluted scheme. While it allows for more than one call to=20 > AC_CONFIG_HEADER, to configure more than one *.hin file, it does not=20 > recognize the idea that autoheader should put any less than all of the=20 > AC_DEFINE()d entries into its output file (newlib.hin). >=20 > So this needs some extra, manual post-processing after running=20 > autoreconf, to remove the duplicate definitions. we already process newlib.h when generating it in configure to filter out some content. we could easily add these specific defines to the filter to avoid confusion/mistakes during autoreconf. i'll send a patch. -mike --YqQUpTzWUgDU2dTO Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCAAdFiEEfjLn+uywF2RXRpXdyTaAqES06MkFAmUrrzIACgkQyTaAqES0 6Mlt/Av/fQh++4yZDDSJVFo3Vnq383nm6GqtYchPeA18x1Ge9JnVzPYOTzhP+a9a CXsHcend1MgUTfWfDQhKnk2q74iLcWtqiXxbOL/D3OkwLEI4p86GgZ5K6Zg9hNq0 CtYo78ayEgl9K9iQAm6wQEeXbcVe6HlnRgPh4u7zD23wCUhT2rWurYF/zvQ+g8d3 vJtXO7L6iD5RO4+wzbp1/RBGUs9tNTyWXDcWfuZKbSuk5Sm0LS8+fGF52E9DlB5D 8L7XXWgKZn/HUrQr5GiwsX8Q37yicu1PLMDELTk9f3lCUo6Fve3tTAs7MQI3XXzj yBerGvzU2NIsgWERYUbeRd8mk/DtCJHQgF2HCnJDx2CY60H3iizbrnpzNXmUsdm5 +kloW1G1HL5VPOSyygw1OmUaltatWNw3U4hB3q+dsemxxeNPmKWMieN0WuPOC6i8 W/u/4UBGYIF3sHtbVLcdfji2AhDQ2TVnlhBf6cd1PNRYlXM4JbsT7YPu5JVLGHwn GqhPYNAg =Szkx -----END PGP SIGNATURE----- --YqQUpTzWUgDU2dTO--