From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=tBo5=F6=gentoo.org=vapier@sourceware.org>
Received: from smtp.gentoo.org (mail.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4])
	by sourceware.org (Postfix) with ESMTP id 0B39B3858412
	for <newlib@sourceware.org>; Mon, 16 Oct 2023 04:55:47 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 0B39B3858412
Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gentoo.org
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gentoo.org
ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 0B39B3858412
Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2001:470:ea4a:1:5054:ff:fec7:86e4
ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1697432148; cv=none;
	b=N3MZYS0MnFQspVZUBCF0i090W6Nc8H6RNMwJBBH1cgcqr5t05uQQvAFT5c5BonQ41CZax3RDK6DCIICB7k33kGK3NK4GkJmqYsefPt35SD+JyAHkfkcgtzxxWoCd+X2L6Ymhj/DOX2jTzq4mSkAitbx0At0RtQt1nXoVlo1UMGk=
ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key;
	t=1697432148; c=relaxed/simple;
	bh=Rz4U9CID97sG6PVjyoeVenl2EbKXTpQpY75J5esszCE=;
	h=Date:From:To:Subject:Message-ID:MIME-Version; b=Bw3YpRbuz5ZnHp2kj25YvR9/eUgA344QerZ20heqHvpwPQDjpDPCyeYhnIh+QIjTIZwBZHJ6GvZekS/H+Amm/er82yUNJDxwXZ5JeRN+fS+DhWrcb3nqhsp+xVvm+whss3ERwAxZDMuFiBvY7/QaUCUytAXxuTtKicrJtpCfkA4=
ARC-Authentication-Results: i=1; server2.sourceware.org
Received: by smtp.gentoo.org (Postfix, from userid 559)
	id 00F76335D17; Mon, 16 Oct 2023 04:55:45 +0000 (UTC)
Date: Mon, 16 Oct 2023 10:40:43 +0545
From: Mike Frysinger <vapier@gentoo.org>
To: Thomas Schwinge <thomas@codesourcery.com>
Cc: newlib@sourceware.org
Subject: Re: [PATCH] newlib: stop clobbering LDFLAGS with non-standard
 $ldflags
Message-ID: <ZSzCTyU+CwUDpl7A@vapier>
References: <20220121045152.21131-1-vapier@gentoo.org>
 <87sfd2cetw.fsf@euler.schwinge.homeip.net>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="Uw9QGcJtuNiHSUxm"
Content-Disposition: inline
In-Reply-To: <87sfd2cetw.fsf@euler.schwinge.homeip.net>
X-Spam-Status: No, score=-5.1 required=5.0 tests=BAYES_00,JMQ_SPF_NEUTRAL,KAM_DMARC_STATUS,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org
List-Id: <newlib.sourceware.org>


--Uw9QGcJtuNiHSUxm
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On 14 Apr 2023 23:51, Thomas Schwinge wrote:
> On 2022-01-20T23:51:52-0500, Mike Frysinger <vapier@gentoo.org> wrote:
> > Adjust the testsuite to match.
>=20
> > --- a/newlib/testsuite/lib/newlib.exp
> > +++ b/newlib/testsuite/lib/newlib.exp
> > @@ -66,13 +66,13 @@ proc newlib_target_compile { source dest type optio=
ns } {
> >           [target_info needs_status_wrapper] !=3D "0" && \
> >           [info exists gluefile] } {
> >       lappend options "libs=3D$gluefile"
> > -     lappend options "ldflags=3D$wrap_flags"
> > +     lappend options "LDFLAGS=3D$wrap_flags"
> >      }
> >
> >      if [string match $host_triplet $target_triplet] then {
> >       if [string match "i686-pc-linux-gnu" $host_triplet] then {
> >           lappend options "libs=3D$objdir/crt0.o -lc -lgcc"
> > -         lappend options "ldflags=3D-nostdlib -L$objdir/.libs [newlib_=
include_flags]"
> > +         lappend options "LDFLAGS=3D-nostdlib -L$objdir/.libs [newlib_=
include_flags]"
> >       }
> >      }
>=20
> ..., is that really correct?  As far as I know, DejaGnu only looks for
> the lower-case 'ldflags' in 'options', as documented in
> '[...]/share/dejagnu/target.exp'.  (I just noticed this while looking for
> something else; I don't have any toolchains exercising the code paths
> you've changed.)

tbh, i'm not sure.  i tried running the testsuite a few ways, but doesn't
seem to really work :/.

would be nice if these worked out of the box better.  maybe with the GNU
sim by default or something.
-mike

--Uw9QGcJtuNiHSUxm
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQGzBAABCAAdFiEEfjLn+uywF2RXRpXdyTaAqES06MkFAmUswk8ACgkQyTaAqES0
6MnvQAwA2H+gtYTBaB42ISGq61T4rC+A+dAao8nrvCHfB7wm+t66gVohq8PHt+I1
d6LK8VrIsPs4hMbhuv02gREhgJGEins8ZHt3bcOG5iCuKb4YUsQ8a1lptDeEXndc
u9OTZXMO5GUgnG3/GPHQjEUr7puBgd3HuF+Ldn5FE3UXJGu7wW2sS5FYsjnPdpRl
rNevPbczyWBN5tFIputFeDl9s539shQAXDZRWbsyaXB95IA+5DXOXdwe8SLU4ojT
mosEMEDxMzkKvy+LTH4z9TrGUSUPS3dIEXZDEIkRkMvrN3mrm3k2DocEDzwg4lYg
WSMzAUe3dEFdDydFi7V1rD5e3qMo+FoT3T+U6UrInAXPRVsKFdoq4UlYTbve9uih
0jyvhBFoz7CoxsL2Gbh2BwIB+QYwk+CKfN/Y/FfdYTlIl+Y3UlODrl/P/3jqgPV7
/olip3cYPQ0fjrWhr8jFpth9YpHbnn83AR7DrgjrQtt8fPHU55WpTd/ZrMCiddz7
y+XXpDSI
=EkCD
-----END PGP SIGNATURE-----

--Uw9QGcJtuNiHSUxm--