From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id F2AC13858C41 for ; Wed, 8 Nov 2023 19:41:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org F2AC13858C41 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org F2AC13858C41 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699472462; cv=none; b=IRgfyoDr3aF8INaUnOUXWnzZE3jtCtk0MTjHLJsEye4HuGRxiiLE7ILivs3HfWfnWpFL7t/uqxpS066uCvGNNn6A7XDKMFGAGdgXXaBPmxSykDxN9Fjz6U6mxMz0L9WbhmrNmyn1FJsfSPEi9ayjaBlZQaD5xqOeB50SYEh113Q= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699472462; c=relaxed/simple; bh=pyoiHu3aZAVUXlKqn5uC78aB+uv17kNSbdmvhLbUJ7w=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=XTJPbVOkxazaIlfLdc4cCMIXpqpsvX0+1QNBSn72cTZc48eJU1IRqoQ5o24eG3CqdZIA/bTk0Mr2IQbJ/B3uAn4iQYJjDpwhJ+454OJEPgJpDHtL95dynruNc3UwEC4zdByPmHc6iqr1vTU0+6y/NceQEOYuRzwCNkimdg0gr+U= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1699472461; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=WcirscZSBzpFgZgDuE2bIONKQK2TrwA4t9zzjEVe7Hg=; b=bprH3/ZHmkemn6rRATNQ7idkUqcTFvGQ4ZM75zsh7/AChZvpqLu+yQ6/brrJe1KH4K7FZn ZDvG3Av3EagIVN0Gqs+Flv3CVaOIdsf7K7lFDyc6gLchOs/qG+YHJ6Lx0e+RlOEovZpvmJ iJiEfJSCTQ71fkdAIDMZe2Es02Th9mA= Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-664-RmFCLGCPNleW-tNkexTt2w-1; Wed, 08 Nov 2023 14:41:00 -0500 X-MC-Unique: RmFCLGCPNleW-tNkexTt2w-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 1F9FC1C05139; Wed, 8 Nov 2023 19:41:00 +0000 (UTC) Received: from calimero.vinschen.de (unknown [10.39.192.157]) by smtp.corp.redhat.com (Postfix) with ESMTPS id ED6922166B26; Wed, 8 Nov 2023 19:40:59 +0000 (UTC) Received: by calimero.vinschen.de (Postfix, from userid 500) id D9A65A807D0; Wed, 8 Nov 2023 20:40:57 +0100 (CET) Date: Wed, 8 Nov 2023 20:40:57 +0100 From: Corinna Vinschen To: Takashi Yano Cc: newlib@sourceware.org Subject: Re: [PATCH v4] newlib: libc: Fix crash on fprintf to a wide-oriented stream. Message-ID: Reply-To: newlib@sourceware.org Mail-Followup-To: Takashi Yano , newlib@sourceware.org References: <20231108120403.643-1-takashi.yano@nifty.ne.jp> MIME-Version: 1.0 In-Reply-To: <20231108120403.643-1-takashi.yano@nifty.ne.jp> X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.6 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Spam-Status: No, score=-5.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Takashi, On Nov 8 21:04, Takashi Yano wrote: > --- a/newlib/libc/stdio/local.h > +++ b/newlib/libc/stdio/local.h > @@ -231,21 +231,23 @@ extern _READ_WRITE_RETURN_TYPE __swrite64 (struct _reent *, void *, > * Set the orientation for a stream. If o > 0, the stream has wide- > * orientation. If o < 0, the stream has byte-orientation. > */ > -#define ORIENT(fp,ori) \ > - do \ > - { \ > - if (!((fp)->_flags & __SORD)) \ > - { \ > - (fp)->_flags |= __SORD; \ > - if (ori > 0) \ > - (fp)->_flags2 |= __SWID; \ > - else \ > - (fp)->_flags2 &= ~__SWID; \ > - } \ > - } \ > - while (0) > +#define ORIENT(fp,ori) \ > + ( \ > + ( \ > + ((fp)->_flags & __SORD) ? \ > + 0 \ > + : \ > + ( \ You're missing to set (fp)->_flags |= __SORD here. > + (ori > 0) ? \ > + ((fp)->_flags2 |= __SWID) \ > + : \ > + ((fp)->_flags2 &= ~__SWID) \ > + ) \ > + ), \ > + (((fp)->_flags2 & __SWID) ? 1 : -1) \ > + ) Thanks, Corinna