From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 715793858C78 for ; Mon, 4 Dec 2023 09:37:23 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 715793858C78 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 715793858C78 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701682644; cv=none; b=Dw+iAQ317vZvd93ZCJUlG9mpaP6a6NTgiW1atK2jRj5AiJSzR0cAl/Lc40HIdVTgehpnsIqOL314XvCgVeKfNosxVQSHtZLRZ12PDvi70lIR6ETT9dozuKIkJkw3VN7xTAA+PwrVkj/oIG7MgLo8RlxwqfJDI2JUIPTQVCDsgFA= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701682644; c=relaxed/simple; bh=KLOsbCAvJYreLsNvMQnSojk39i4XXz1rC0544SPu2P8=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=ncF36OIaimsWNm6qOirsB8/k8XHmm2Hgo/TsAeHsxZbQcl9OwGHFwtEXtETdNaBpITobVuk88aFAiDb259lkz8lHnTs43G3DKexENZnBTazmdLeTFfRfBNZKhelC+k+Tsn7DkkZNFlP0HVjtTsC1SMxIeDKGd1wWKCngI7SGOkk= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1701682643; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=WCeQs0e+nX6olI8H3h+ZFl17zHFsPOGl5kbDl0hmEGU=; b=GaeuanJ3B85pKEeVzJNa/AeI+yJ4iepN/5ZfbxK4zIRT9KEejeKCWhTZKCrykH+mgQx9Rc VNaT6A3Jn71BywWbtWAGC+QptXfA+T5RMRCAD6Q/LL/n6usDjyquTn2K3L9xY4Y5gihBgX XAm+7v2avzduFUTzzXwNYE/UMrzk610= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-632-S590WmU_OMySiZlEHkpKBQ-1; Mon, 04 Dec 2023 04:37:20 -0500 X-MC-Unique: S590WmU_OMySiZlEHkpKBQ-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id CCA0E85A58B; Mon, 4 Dec 2023 09:37:19 +0000 (UTC) Received: from calimero.vinschen.de (unknown [10.39.192.52]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A6EC71121306; Mon, 4 Dec 2023 09:37:19 +0000 (UTC) Received: by calimero.vinschen.de (Postfix, from userid 500) id 4D8DFA80B86; Mon, 4 Dec 2023 10:37:18 +0100 (CET) Date: Mon, 4 Dec 2023 10:37:18 +0100 From: Corinna Vinschen To: Kito Cheng Cc: newlib@sourceware.org, kito.cheng@gmail.com Subject: Re: [PATCH] RISC-V: Support long double math Message-ID: Reply-To: newlib@sourceware.org Mail-Followup-To: Kito Cheng , newlib@sourceware.org, kito.cheng@gmail.com References: <20231204074139.17629-1-kito.cheng@sifive.com> MIME-Version: 1.0 In-Reply-To: <20231204074139.17629-1-kito.cheng@sifive.com> X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.3 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Spam-Status: No, score=-10.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Kito, thanks, both patches pushed. I just wonder... On Dec 4 15:41, Kito Cheng wrote: > diff --git a/newlib/libc/machine/riscv/machine/_fpmath.h b/newlib/libc/machine/riscv/machine/_fpmath.h > new file mode 100644 > index 000000000..fa62ae81c > --- /dev/null > +++ b/newlib/libc/machine/riscv/machine/_fpmath.h > @@ -0,0 +1,64 @@ > [...] > +union IEEEl2bits { > + long double e; > + struct { > + uint64_t manl :64; > + uint64_t manh :48; > + uint32_t exp :15; > + uint32_t sign :1; > + } bits; > + /* TODO andrew: Check the packing here */ ...if Andrew already checked the packaging, after he pushed this to the FreeBSD repo in 2015 :))) Thanks, Corinna