From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 0ABFB385C317 for ; Mon, 4 Dec 2023 16:38:35 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 0ABFB385C317 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 0ABFB385C317 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701707917; cv=none; b=otJ0BxK1h2yUYSl5L9HJpHsHCopn3d91EIKVbAcaF2hZuKE9UduQSe4X08bjhHqMk2TUJKxvjTs0uyMgp1uaAzhPkI5Z/yMc7E9AvXaRVOmnvY9htWfkKmSPYQ36bkvoUeWMiPeJ3358iUyhY6pEQ997++5JsmJsxbARvi+MY9A= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701707917; c=relaxed/simple; bh=kGokumnOBITHh8T9gzqAgn2iFHM5BRzMumWg7VpU+TU=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=MXt+vErATLMA/E+w2ohwUHwTfLvNZWQEsOupelPzRevsGv2Oc1a3U22iA8wUK9HLr9F9pRtCqHc21MiNV08u6236PfBu6GJUJXPmxIRumLOtVoFErsa2holLlRqmd2dIVhz76bTeyKt68axrJhvok4yeUsuI9YCQB0NZZJ2Sjk0= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1701707915; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=8vL+l8mjYgEUGRXY17XGdkyIex8I2xKHRYJfN8DlYiE=; b=Nkty3Cnc2qmjjznoa1ipjPP5CMNo9r2GZXmpWvUpOvvDz6cqvzq2cQ1Qgb9nWsZAoyF+t8 8ADGvHQQW7KNz9QVtpKvbD2CLNnGvIeV99FlMctNIvsVaRrbVfe0Xa26c8c1vdGuEKRI5H BCMO+IkmSyd7JuFuFTl0Fms1furLWjI= Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-537-_n6uZlc5PmKkgFhCeEEsKg-1; Mon, 04 Dec 2023 11:38:32 -0500 X-MC-Unique: _n6uZlc5PmKkgFhCeEEsKg-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id DC2751C07552; Mon, 4 Dec 2023 16:38:31 +0000 (UTC) Received: from calimero.vinschen.de (unknown [10.39.192.52]) by smtp.corp.redhat.com (Postfix) with ESMTPS id BAB2740C6EB9; Mon, 4 Dec 2023 16:38:31 +0000 (UTC) Received: by calimero.vinschen.de (Postfix, from userid 500) id 51BF0A80B86; Mon, 4 Dec 2023 17:38:30 +0100 (CET) Date: Mon, 4 Dec 2023 17:38:30 +0100 From: Corinna Vinschen To: Dimitar Dimitrov Cc: newlib@sourceware.org Subject: Re: [PATCH] pru: libm: Fix incorrect function name Message-ID: Reply-To: newlib@sourceware.org Mail-Followup-To: Dimitar Dimitrov , newlib@sourceware.org References: <20231204154242.1391291-1-dimitar@dinux.eu> MIME-Version: 1.0 In-Reply-To: <20231204154242.1391291-1-dimitar@dinux.eu> X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.2 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Spam-Status: No, score=-11.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Dec 4 17:42, Dimitar Dimitrov wrote: > Upstream GCC changed -Wimplicit-function-declaration warning into an > error. The build break about missing fpclassifyf function prototype > exposed a bug in the PRU port of libm. > > The fix is to use the fpclassify macro for both double and float types. > > Signed-off-by: Dimitar Dimitrov > --- > newlib/libm/machine/pru/fpclassifyf.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/newlib/libm/machine/pru/fpclassifyf.c b/newlib/libm/machine/pru/fpclassifyf.c > index f4dd201d9..6d82ea777 100644 > --- a/newlib/libm/machine/pru/fpclassifyf.c > +++ b/newlib/libm/machine/pru/fpclassifyf.c > @@ -32,5 +32,5 @@ > by TI ABI. */ > int __pruabi_fpclassifyf(float a) > { > - return fpclassifyf(a); > + return fpclassify(a); > } > -- > 2.43.0 Pushed. Thanks, Corinna