public inbox for newlib@sourceware.org
 help / color / mirror / Atom feed
From: Corinna Vinschen <vinschen@redhat.com>
To: Kuan-Wei Chiu <visitorckw@gmail.com>
Cc: newlib@sourceware.org, kito.cheng@sifive.com
Subject: Re: [PATCH v2] RISC-V: Fix timeval conversion in _gettimeofday()
Date: Wed, 29 Nov 2023 10:15:44 +0100	[thread overview]
Message-ID: <ZWcBQDYtkb21LPGn@calimero.vinschen.de> (raw)
In-Reply-To: <20231129035714.469943-1-visitorckw@gmail.com>

On Nov 29 11:57, Kuan-Wei Chiu wrote:
> Replace multiplication with division for microseconds calculation from
> nanoseconds in _gettimeofday function.
> 
> Signed-off-by: Kuan-Wei Chiu <visitorckw@gmail.com>
> ---
> v1 -> v2:
>    - Add missing Signed-off-by tag.
> 
>  libgloss/riscv/sys_gettimeofday.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/libgloss/riscv/sys_gettimeofday.c b/libgloss/riscv/sys_gettimeofday.c
> index 81bea8e55..5379a8963 100644
> --- a/libgloss/riscv/sys_gettimeofday.c
> +++ b/libgloss/riscv/sys_gettimeofday.c
> @@ -23,7 +23,7 @@ _gettimeofday(struct timeval *tp, void *tzp)
>    int rv;
>    rv = syscall_errno (SYS_clock_gettime64, 2, 0, (long)&ts64, 0, 0, 0, 0);
>    tp->tv_sec = ts64.tv_sec;
> -  tp->tv_usec = ts64.tv_nsec * 1000;
> +  tp->tv_usec = ts64.tv_nsec / 1000;
>    return rv;
>  #else
>    return syscall_errno (SYS_gettimeofday, 1, tp, 0, 0, 0, 0, 0);
> -- 
> 2.25.1

Pushed.


Thanks,
Corinna


      parent reply	other threads:[~2023-11-29  9:15 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-28 22:37 [PATCH] " Kuan-Wei Chiu
2023-11-29  3:57 ` [PATCH v2] " Kuan-Wei Chiu
2023-11-29  6:41   ` Kito Cheng
2023-11-29  9:15   ` Corinna Vinschen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZWcBQDYtkb21LPGn@calimero.vinschen.de \
    --to=vinschen@redhat.com \
    --cc=kito.cheng@sifive.com \
    --cc=newlib@sourceware.org \
    --cc=visitorckw@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).