Re: [PATCH] RISC-V: fix setting up std streams in init_semihosting()

[Corinna Vinschen <vinschen@redhat.com>]

On Jan 10 07:57, Ram Nalamothu (QUIC) wrote:
> Hi,
> 
> What is missing for this patch to be pushed?
> If nothing, could someone please help me by applying this patch.

Pushed.

Thanks,
Corinna

> 
> Regards,
> Ram
> 
> -----Original Message-----
> From: Ram Nalamothu (QUIC) <quic_vnalamot@quicinc.com> 
> Sent: Friday, January 5, 2024 5:22 PM
> To: newlib@sourceware.org
> Cc: craig.blackmore@embecosm.com; kito.cheng@sifive.com
> Subject: RE: [PATCH] RISC-V: fix setting up std streams in init_semihosting()
> 
> Ping
> 
> -----Original Message-----
> From: Kito Cheng <kito.cheng@sifive.com>
> Sent: Wednesday, January 3, 2024 1:48 PM
> To: Ram Nalamothu (QUIC) <quic_vnalamot@quicinc.com>
> Cc: newlib@sourceware.org; craig.blackmore@embecosm.com
> Subject: Re: [PATCH] RISC-V: fix setting up std streams in init_semihosting()
> 
> WARNING: This email originated from outside of Qualcomm. Please be wary of any links or attachments, and do not enable macros.
> 
> The change seems weird to me at my first time reading, however it makes sense after reading _open and __add_fdentry.
> 
> So LGTM, thanks for fixing this issue :)
> 
> (BTW, I don't have commit right either :P)
> 
> On Wed, Jan 3, 2024 at 4:03 PM Ram Nalamothu (QUIC) <quic_vnalamot@quicinc.com> wrote:
> >
> > Without this patch, the following simple test would fail to run as expected.
> >
> > #include <stdio.h>
> > int main() {
> >   int n;
> >   printf("Enter a number\n");
> >   scanf("%d", &n);
> >   printf("Entered number: %d\n", n);
> >   return 0;
> > }
> >
> > If the patch looks good, could someone please commit it on behalf of me as I don't have commit rights.
> >
> > -- 8< --
> >
> > Currently init_semihosting() assumes the return value from _open() 
> > call as the file descriptor handle and that is incorrect.
> >
> > The semihost _open() call returns the fdtable index returned by the
> > __add_fdentry() for the file opened.