From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id B3D6B3858D38 for ; Wed, 10 Jan 2024 09:53:21 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B3D6B3858D38 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org B3D6B3858D38 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1704880403; cv=none; b=nMA1QwHKRGnS9hfT01NAY7CfyWse8MPRvRGUqgGYbYI8LDKCc8JtrJxe0bBKG4Y54hmheZlFp0HTj65/ulTGi+LhcBpxFImqBUBbWH0+I17oW1u33AsE2NvmxWKWevonDlVJ6gV/OdXzQShQqDe1OHWvttQMnVnB8WEVRq3MPb0= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1704880403; c=relaxed/simple; bh=s2bdZuVwk1hDiRq2MpAmeTYwKipvieDuuPozWorg1Bg=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=pynNlXxi9uN+GoZGKGawtBnBzAnmuG+DC6dtaEtI1hGikzaKZamCU8exdbZEEBnAT+wPS2iTH0UCCU9JlU0pX6PDwUcgvTeuxq3VaPuwDaX0Y7E5HgaahdrH8fvL+UfYOY0AcwyuQh0Q9Cj3MJntsr+iIiGcUYWOITeO87UrBrE= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1704880401; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=TBwJK1I6pE1IGw99Vtq3RkA6trF7Te8B6+MmaBuMDT4=; b=XCRFiPO8aLu7jgvwUA8NY0um4OjohA/x8zcnxliRABTyiY3eKFsjb10xxf+OT0H6DPWubC Wg+WMtKr8RtVCC/asFIB0LAppS1eIxVRA92lHR8l8r0OOvPpK1WP1CWPjlLo0fbwWb1wuq n5lXv1aUuX5Fc04pm0BAha46y/BvQ9g= Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-517-Ul9Sui4jMfGVkZf935-PHw-1; Wed, 10 Jan 2024 04:53:18 -0500 X-MC-Unique: Ul9Sui4jMfGVkZf935-PHw-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id CF3F43869140; Wed, 10 Jan 2024 09:53:17 +0000 (UTC) Received: from calimero.vinschen.de (unknown [10.39.195.34]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 65A5740C6EB9; Wed, 10 Jan 2024 09:53:17 +0000 (UTC) Received: by calimero.vinschen.de (Postfix, from userid 500) id 35FB9A80742; Wed, 10 Jan 2024 10:53:16 +0100 (CET) Date: Wed, 10 Jan 2024 10:53:16 +0100 From: Corinna Vinschen To: newlib@sourceware.org Cc: Mike Frysinger , "Frager, Neal" , "jjohnstn@redhat.com" , "thomas.petazzoni@bootlin.com" , "cjwfirmware@vxmdesign.com" Subject: Re: [PATCH v2 1/1] configure.ac: configurable tooldir install path Message-ID: Reply-To: newlib@sourceware.org Mail-Followup-To: newlib@sourceware.org, Mike Frysinger , "Frager, Neal" , "jjohnstn@redhat.com" , "thomas.petazzoni@bootlin.com" , "cjwfirmware@vxmdesign.com" References: <20240109103953.1112223-1-neal.frager@amd.com> MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.2 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Spam-Status: No, score=-12.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: [CC Mike] Maybe we should switch newlib/cygwin to 2.71 as well, eventually? We're in the process of preparing the next Cygwin release which should be due end of this month. After that I don't see any reason that we can't bumb the configury to the latest autotools. Corinna On Jan 9 14:18, Frager, Neal wrote: > Hi Jeff, Thomas, > > Thank you both for your assistance with the patch below. > > I am now dealing with a version conflict between newlib and buildroot. > I hope you can help me find the best solution for it. > > On my machine, I have tested the patch below using autoconf 2.69. > > However, the goal is for this patch is to ultimately integrate with > buildroot. > > Currently, buildroot hardcodes the autoconf version that it builds > and uses to version 2.71. > > But with autoconf version 2.71, I get the following error from the > newlib configure.ac because it requires specifically version 2.69: > > >>> newlib-bare-metal 4.3.0 Autoreconfiguring > configure.ac:34: error: Please use exactly Autoconf 2.69 instead of 2.71. > config/override.m4:12: _GCC_AUTOCONF_VERSION_CHECK is expanded from... > configure.ac:34: the top level > > As you are newlib and buildroot maintainers, could you > please help me with guidance about how to resolve this > issue? > > I can easily make a patch to make the autoconf version used > by buildroot configurable, but I would like your opinions > before I proceed. > > Thank you again for your support! > > Best regards, > Neal Frager > AMD > > > This patch is required to fix how the newlib headers are installed > > when using a sysroot install directory. > > > The cross compiler expects headers to be in > > .../host/usr/arm-none-eabi/sysroot/usr/include/newlib.h > > by default newlib installed the headers into > > .../host/usr/arm-none-eabi/sysroot/usr/arm-none-eabi/include/newlib.h > > > ${exec_prefix} provides the .../host/usr/arm-none-eabi/sysroot path > > ${target_noncanonical} provides an extra arm-none-eabi/ that must be removed. > > > With this patch, users can specify the tooldir path that is needed. > > > Signed-off-by: Neal Frager > > Co-developed-by: Chris Wardman > > --- > > V1->V2: > > - migrated patch to configure.ac > > - changed option name to --with-tooldir=PATH > > --- > > configure.ac | 13 ++++++++++++- > > 1 file changed, 12 insertions(+), 1 deletion(-) > > > diff --git a/configure.ac b/configure.ac > > index f1bb72100..9a01c1562 100644 > > --- a/configure.ac > > +++ b/configure.ac > > @@ -2599,7 +2599,18 @@ esac > > > # Some systems (e.g., one of the i386-aix systems the gas testers are > > # using) don't handle "\$" correctly, so don't use it here. > > -tooldir='${exec_prefix}'/${target_noncanonical} > > +AC_ARG_WITH([tooldir], > > + [AS_HELP_STRING([--with-tooldir=PATH], > > + [use given path to install target tools after build])], > > + [case x"$withval" in > > + x/*) ;; > > + *) > > + with_tooldir= > > + AC_MSG_WARN([argument to --with-tooldir must be an absolute path]) > > + ;; > > + esac], > > + [with_tooldir='${exec_prefix}'/${target_noncanonical}]) > > +tooldir='${with_tooldir}' > > build_tooldir=${tooldir} > > > # Create a .gdbinit file which runs the one in srcdir > > -- > > 2.25.1