public inbox for newlib@sourceware.org
 help / color / mirror / Atom feed
From: Mike Frysinger <vapier@gentoo.org>
To: Dimitar Dimitrov <dimitar@dinux.eu>
Cc: newlib@sourceware.org
Subject: Re: [PATCH v2 1/2] libgloss: merge pru into top-level Makefile
Date: Wed, 3 Jan 2024 16:48:05 -0500	[thread overview]
Message-ID: <ZZXWFVIIiFnWfUXP@vapier> (raw)
In-Reply-To: <20240103175655.1394938-1-dimitar@dinux.eu>

[-- Attachment #1: Type: text/plain, Size: 638 bytes --]

On 03 Jan 2024 19:56, Dimitar Dimitrov wrote:
> --- /dev/null
> +++ b/libgloss/pru/Makefile.inc
> @@ -0,0 +1,48 @@
> +## SPDX-License-Identifier: BSD-2-Clause-FreeBSD
> +##
> +## Copyright 2018-2024 Dimitar Dimitrov <dimitar@dinux.eu>
> +### All rights reserved.

only need ## here, not ###

> +multilibtool_DATA += \
> +	%D%/crt0.o \
> +	%D%/crt0-minrt.o
> +
> +pru_devicespecsdir = $(multilibtooldir)/device-specs
> +pru_devicespecs_DATA = %D%/device-specs/sim
> +
> +libobjs_a_SOURCES += \
> +	%D%/crt0.S \
> +	%D%/crt0-minrt.S

i've been grouping libobjs_a_SOURCES right after multilibtool_DATA so it's
clear they're "together"
-mike

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

      parent reply	other threads:[~2024-01-03 21:48 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-02  8:24 [PATCH " Dimitar Dimitrov
2024-01-02  8:24 ` [PATCH 2/2] libgloss: pru: Trim crt0-minrt.o Dimitar Dimitrov
2024-01-02 13:15 ` [PATCH 1/2] libgloss: merge pru into top-level Makefile Mike Frysinger
2024-01-03 17:56 ` [PATCH v2 " Dimitar Dimitrov
2024-01-03 17:56   ` [PATCH v2 2/2] libgloss: pru: Trim crt0-minrt.o Dimitar Dimitrov
2024-01-03 21:48   ` Mike Frysinger [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZZXWFVIIiFnWfUXP@vapier \
    --to=vapier@gentoo.org \
    --cc=dimitar@dinux.eu \
    --cc=newlib@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).