From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.gentoo.org (smtp.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) by sourceware.org (Postfix) with ESMTP id 279DC3858D32 for ; Thu, 4 Jan 2024 23:54:45 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 279DC3858D32 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gentoo.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gentoo.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 279DC3858D32 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2001:470:ea4a:1:5054:ff:fec7:86e4 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1704412487; cv=none; b=r6koT1fFAMfoshlLdG24eD6UL3vtWqDEeSHtQdYVU4ZzFmbKSTT7YujVHtOibrk+mVH83NokQ1FVOD4AK2StPUz5+DN1tml1xN1EOnUETYGZ2sZW0gYdXXETok6UthXRt3CRe+QlhQot5v0d1+cc9kFhp7Nu718wKd2OsTwlwLc= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1704412487; c=relaxed/simple; bh=Vn6OgU0ldxrjzwXqZTtrYpmVxwhHfn/fAf3MdsrTZOc=; h=Date:From:To:Subject:Message-ID:MIME-Version; b=ob3WzcIG8r3jBMFMESLypbmn6SZC2VFqcijdz3IMfR+zMihFPY/eCvZD0Mbd5KzlYI//GoDnrCEsloxXcQWl3LVtba5LcVEF67i0SEMFcalNxgkOZLDTYRd/UTq4oug40MDjEr2+lT1Dqlvy6nGj8Tg+ZEcaE3V9LtPjFWJXBuM= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by smtp.gentoo.org (Postfix, from userid 559) id AC2AE343094; Thu, 4 Jan 2024 23:54:44 +0000 (UTC) Date: Thu, 4 Jan 2024 18:54:43 -0500 From: Mike Frysinger To: Roger Sayle Cc: newlib@sourceware.org, 'Jeff Law' Subject: Re: [PATCH] libgloss: Resolve compilation errors for mips. Message-ID: References: <00ac01da3f16$2e292610$8a7b7230$@nextmovesoftware.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="6nIUkDKvNOXjibDx" Content-Disposition: inline In-Reply-To: <00ac01da3f16$2e292610$8a7b7230$@nextmovesoftware.com> X-Spam-Status: No, score=-5.3 required=5.0 tests=BAYES_00,JMQ_SPF_NEUTRAL,KAM_DMARC_STATUS,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --6nIUkDKvNOXjibDx Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 04 Jan 2024 13:59, Roger Sayle wrote: > --- a/libgloss/kill.c > +++ b/libgloss/kill.c > > +extern void _exit (int); missing noreturn markings. can this file include stdlib.h instead ? > --- a/libgloss/mips/cfe_mem.c > +++ b/libgloss/mips/cfe_mem.c > > - memtop =3D __libcfe_mem_limit (); > + memtop =3D (unsigned long)__libcfe_mem_limit (); if memtop is supposed to be a pointer, then it should be a pointer, not an integer. ignoring that, never use long or int to cast pointers. this is what uintptr_t is designed for. > --- a/libgloss/mips/syscalls.c > +++ b/libgloss/mips/syscalls.c > > extern char _end[]; > +extern void *get_mem_info (void*); seems like mips should have a header for its prototypes rather than duplica= ting it across multiple files, and so it makes sure it's defined correctly both = in the callers & definitions. seems like get_mem_info takes a struct pointer,= not a void. > - if (((size_t)heap_ptr >=3D heap_start) && ((size_t)heap_ptr < (heap_st= art + mem.size))) { > - avail =3D (heap_start + mem.size) - (size_t)heap_ptr; > + if ((heap_ptr >=3D heap_start) && (heap_ptr < (heap_start + mem.size))= ) { > + avail =3D (unsigned int)((heap_start + mem.size) - heap_ptr); use ptrdiff_t to hold the difference between pointers, don't cast like this. > --- a/libgloss/print.c > +++ b/libgloss/print.c > > #include "glue.h" > > +extern int outbyte (char x); outbyte is already defined in glue.h which is included here > --- a/libgloss/putnum.c > +++ b/libgloss/putnum.c > @@ -14,7 +14,7 @@ > */ > #include "glue.h" > =20 > -extern void print (char *ptr); > +extern void print (const char *ptr); this prob should be moved to glue.h instead -mike --6nIUkDKvNOXjibDx Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEuQK1JxMl+JKsJRrUQWM7n+g39YEFAmWXRUMACgkQQWM7n+g3 9YGlCA/8CBqvot4ulTZQ0VERIfJToGkaZC0vxcJ2lLZaRuiv+YaKoXAJ/ObVKrIL nkaX8yfKSdCoGimHPnsGZGfzNjkZ01ghT/8Zq2VGS8lf3LJ5QsH9I67C1WR/5FUv 7BbBwaiYWrxMfeg9KxEGtZaVIdJ0fxzKOtVlYYhqIrW8y2SB1viS/kLpt2c919Ey RDE2/9mffpXUSz/27dmoQRlcuQ01seBYsoSfutMfec7XC6/vjWUcpmWqSLfvglY5 VhIGfXiaNxBxVOq4xF1JfoP4YQFBGhfORpez6D9bLVx/pjawRau0YwhjFkgajfX6 0jUgcwfT+VRFRk9VslrHL7fwaEqRl2D+qGDsHLHNuDCYzLV3scJNvusvOaZmj9FB xn19g3X3CX60OH8O/vdFYrd/cfM/B4zWf9qk0W0KAl9F4RpyXtqJpJ75z78dfOuw Twli8podNevRkgeqcG6AgYQx+gHG2615nEHWFKGY3ibTLVf+GJR3jA22kva/geS9 zRUBqx6rtHMEzzaOz5ajYoWaYuY58RLHVKEeDwMZtgzsThHRLW+s2yysLD2StLZa UfgRyfNLIuV0IHo896jlX6PkNjkth1yUnzn9PAn9XtTUr/VDjr49+FOSaW2tjh// P/6B026Sr58YnVGkYpv9iBVPuzReBdYiXa1jTCr6lGtIHRJrGuk= =5FRF -----END PGP SIGNATURE----- --6nIUkDKvNOXjibDx--