From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id ADE283858429 for ; Tue, 23 Jan 2024 08:53:34 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org ADE283858429 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org ADE283858429 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1706000022; cv=none; b=jzA4F9I2Wsf/rS2XAtfg9ceae2svWnrPNtlg2VhOL50PvAsrZDe6aoO1pTczxP1uRbtsdC6WiyR5YETldmnaQegL/N4IN0VQcGg+kiSgEMVrvnZHuOQRj4C8g3qL/4vtasVezEAhi2LAypdY3qaE+JYWxXraVauSxwKVyXhHlv0= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1706000022; c=relaxed/simple; bh=mPxFzi1SPULWgTebuWGfCam9hPANT01CgoQUR6dEsS4=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=EvHF7R6/Dhtazcg0/eVPUwQSElbP7cCKzFcqIJypT6S0Vk56vJGCDMZNJrECOeGLgmmm6PeQEMTr1TkQWSqy7wSFbjfJ8y3I+HMHg8sCafAiJTDzDfEo+g2DVO8YYnNnXbws/7Ct8BHq6RBJnE2Zg6HaAv4tqqtBN64wBwBrFr4= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1706000014; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=QmDbXH0PmsiL4OdxebTk1SxrqW8bYgn26cqpuKRWRs8=; b=UdNdO4FoO2DeY9oomskWwurbTuNSsfnf+TGyClL3cilLOPyvDSM0Q3y5TPtwRS6Q4qtErm m2ePrkmEQVj6hRX8/TrDuH+CiQq3pMJKYD35D4qtxBnpIkrw+LuB+bozaDzRc+cHp4liXx Wj88pMYdYJSF2AWgnkuUZZ7YF3sUVqc= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-126-aUW2IoRBMhSCyYgaLov6nw-1; Tue, 23 Jan 2024 03:53:32 -0500 X-MC-Unique: aUW2IoRBMhSCyYgaLov6nw-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id F2D83108BE00; Tue, 23 Jan 2024 08:53:31 +0000 (UTC) Received: from calimero.vinschen.de (unknown [10.39.192.49]) by smtp.corp.redhat.com (Postfix) with ESMTPS id C5BA2C2E0EA; Tue, 23 Jan 2024 08:53:31 +0000 (UTC) Received: by calimero.vinschen.de (Postfix, from userid 500) id 78C66A806DE; Tue, 23 Jan 2024 09:53:30 +0100 (CET) Date: Tue, 23 Jan 2024 09:53:30 +0100 From: Corinna Vinschen To: Neal Frager Cc: newlib@sourceware.org, cjwfirmware@vxmdesign.com, jjohnstn@redhat.com, thomas.petazzoni@bootlin.com, vapier@gentoo.org Subject: Re: [PATCH v5 1/1] configure.ac: configurable tooldir install path Message-ID: Reply-To: newlib@sourceware.org Mail-Followup-To: Neal Frager , newlib@sourceware.org, cjwfirmware@vxmdesign.com, jjohnstn@redhat.com, thomas.petazzoni@bootlin.com, vapier@gentoo.org References: <20240111183019.121397-1-neal.frager@amd.com> MIME-Version: 1.0 In-Reply-To: <20240111183019.121397-1-neal.frager@amd.com> X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.8 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Spam-Status: No, score=-11.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Jan 11 18:30, Neal Frager wrote: > This patch is required to fix how the newlib headers are installed > when using a sysroot install directory. > > The cross compiler expects headers to be in > .../host/usr/arm-none-eabi/sysroot/usr/include/newlib.h > by default newlib installed the headers into > .../host/usr/arm-none-eabi/sysroot/usr/arm-none-eabi/include/newlib.h > > ${exec_prefix} provides the .../host/usr/arm-none-eabi/sysroot path > ${target_noncanonical} provides an extra arm-none-eabi/ that must be removed. > > With this patch, users can specify the tooldir path that is needed. > > Signed-off-by: Neal Frager > Co-developed-by: Chris Wardman > --- > V1->V2: > - migrated patch to configure.ac > - changed option name to --with-tooldir=PATH > V2->V3: > - removed quotes around ${with_tooldir} > V3->V4: > - migrated case to AS_CASE > - migrated AC_MSG_WARN to AC_MSG_ERROR > V4->V5: > - remove unnecessary with_tooldir clear when erroring out > --- > configure.ac | 10 +++++++++- > 1 file changed, 9 insertions(+), 1 deletion(-) > > diff --git a/configure.ac b/configure.ac > index f1bb72100..0badf1d30 100644 > --- a/configure.ac > +++ b/configure.ac > @@ -2599,7 +2599,15 @@ esac > > # Some systems (e.g., one of the i386-aix systems the gas testers are > # using) don't handle "\$" correctly, so don't use it here. > -tooldir='${exec_prefix}'/${target_noncanonical} > +AC_ARG_WITH([tooldir], > + [AS_HELP_STRING([--with-tooldir=PATH], > + [use given path to install target tools after build])], > + [AS_CASE([x"$withval"], > + [x/*],, > + [AC_MSG_ERROR([argument to --with-tooldir must be an absolute path])]) > + ], > + [with_tooldir='${exec_prefix}'/${target_noncanonical}]) > +tooldir=${with_tooldir} > build_tooldir=${tooldir} > > # Create a .gdbinit file which runs the one in srcdir > -- > 2.25.1 Pushed. Thanks, Corinna