From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 402A03858284 for ; Tue, 23 Jan 2024 08:54:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 402A03858284 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 402A03858284 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1706000055; cv=none; b=ZMS0juNFtW5beRkj7RQdXVu/jGQHIXIOoUzoSPCXhMYAtwr8iLPljcxgfCITQAtGidG2NaZxthDoA27O+IXGnb1Fy/kRBd4lF+QdlUnVzuzEqNsW4VjQSfm1jlTwGIS0KVNHAXlO3rwBOABhHSg50isjA2bBAngPOmnW8rTloE8= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1706000055; c=relaxed/simple; bh=NT5EMuTmmOb3981gaCK7nGWSigWkhCtCauARdh+WLog=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=njP19W4RaSL8luMvN9xThj8nFjAILCoMUhJq5PpGPyr4J/uFmFCMrT4h5duKCTJrvOWz2E/F65Q8eV4VZPIBK3F7SBhG0skCV4H34f0eF+Hl6oDdQwjqqS9PePXGeC3j3iJp+kE+PaLyVX1fDbt1ygyJImmdwzgZ91a92tEISww= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1706000051; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=YjK0LIULNDmwRwHAzpHrprRwuV9O4YNVjQORRBdj8cw=; b=Ohqr54YpVEs+v3o2cLFDRY/TdIkvRdVNvJet7cxf0+cv7HfMtvdvAtrXWucUddo+N9ltpD H1ZgLNJ9ptGF6Ac7b4rH6VVsl6vhuFDsMIwK/H5usjIwmf/RghWbpw6ddIkElaPcALy5Kt uO2jtWCKvavujBqcpqVLBjhile9QrvI= Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-255-Y9R3Q737NT6TKY-ol4a5dA-1; Tue, 23 Jan 2024 03:54:09 -0500 X-MC-Unique: Y9R3Q737NT6TKY-ol4a5dA-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 2E3742806414; Tue, 23 Jan 2024 08:54:09 +0000 (UTC) Received: from calimero.vinschen.de (unknown [10.39.192.49]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 0D3CD51D5; Tue, 23 Jan 2024 08:54:08 +0000 (UTC) Received: by calimero.vinschen.de (Postfix, from userid 500) id BCF6FA80890; Tue, 23 Jan 2024 09:54:07 +0100 (CET) Date: Tue, 23 Jan 2024 09:54:07 +0100 From: Corinna Vinschen To: Dimitar Dimitrov Cc: newlib@sourceware.org Subject: Re: [PATCH v4 1/2] libgloss: merge pru into top-level Makefile Message-ID: Reply-To: newlib@sourceware.org Mail-Followup-To: Dimitar Dimitrov , newlib@sourceware.org References: <20240122161136.4103003-1-dimitar@dinux.eu> MIME-Version: 1.0 In-Reply-To: <20240122161136.4103003-1-dimitar@dinux.eu> X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.5 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Spam-Status: No, score=-5.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Jan 22 18:11, Dimitar Dimitrov wrote: > Avoid a recursive make to speed things up a bit. This change was > inspired by the recent similar patch for c6x: > https://sourceware.org/pipermail/newlib/2023/020869.html > > While at it, fork crt0-minrt.S into a separate source file instead of > relying on a predefined macro to generate two different object files. > This improves clarity, simplifies the build rules, and would allow > further optimization in crt0-minrt.S to be implemented more cleanly. > > Signed-off-by: Dimitar Dimitrov > --- > Changes since v3: > - Rebased. > > Changes since v2: > - Rearrange Makefile.inc code chunks. > - Whitespace fix. > > Changes since v1: > - Retained copyright in pru/Makefile.inc. > - Addec crt0*.s to libobjs_a_SOURCES. > - Rebased. > > libgloss/Makefile.am | 3 + > libgloss/configure.ac | 7 +- > libgloss/pru/Makefile.in | 145 -------------------------------------- > libgloss/pru/Makefile.inc | 48 +++++++++++++ > libgloss/pru/crt0-minrt.S | 59 ++++++++++++++++ > libgloss/pru/crt0.S | 6 -- > 6 files changed, 113 insertions(+), 155 deletions(-) > delete mode 100644 libgloss/pru/Makefile.in > create mode 100644 libgloss/pru/Makefile.inc > create mode 100644 libgloss/pru/crt0-minrt.S Series pushed. Thanks, Corinna