From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.gentoo.org (woodpecker.gentoo.org [140.211.166.183]) by sourceware.org (Postfix) with ESMTP id D46143858004 for ; Thu, 11 Jan 2024 15:41:24 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D46143858004 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gentoo.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gentoo.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org D46143858004 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=140.211.166.183 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1704987686; cv=none; b=YGRtuhPl11LiWo3Wmid0Ec6APqTvsYWAmtBmUSOVG/exSr7wqjfLhImCEwYNgRyAKYPxW2sZqXN7H/naxvSj2UIh7raNGgIPdSaKo5Sf0n0GN4dGT7ij8TxMqJMYW/il9KOaG4jhTQXbhkthtobjGeg1nJwktfCp0d5IPjyaM7U= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1704987686; c=relaxed/simple; bh=BOaifB9PHQoWa9taPxhNEc/NxLcZQEQ+p7so6j/cvRw=; h=Date:From:To:Subject:Message-ID:MIME-Version; b=K1Yn5vmwbXIDo1Zqku8JtY/NqQU5ps7gTgwBTjZLQ1OEobcLBcOZOPhLM4ps4mSwNkPkxuesWEcBxYnpn5hYAom70zHP6nY+8gHZqp2Fswkbua7hW7yA3w7hhdo7K6/p/srRhnqGaM7RkJTzXjspIXAe2S5JlSE08byXgeW20cg= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by smtp.gentoo.org (Postfix, from userid 559) id 8216D343186; Thu, 11 Jan 2024 15:41:24 +0000 (UTC) Date: Thu, 11 Jan 2024 10:41:22 -0500 From: Mike Frysinger To: Neal Frager Cc: newlib@sourceware.org, cjwfirmware@vxmdesign.com, jjohnstn@redhat.com, thomas.petazzoni@bootlin.com Subject: Re: [PATCH v3 1/1] configure.ac: configurable tooldir install path Message-ID: References: <20231215095529.739093-1-neal.frager@amd.com> <20240111105027.3382376-1-neal.frager@amd.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="vxOzx4JjWcK91pl3" Content-Disposition: inline In-Reply-To: <20240111105027.3382376-1-neal.frager@amd.com> X-Spam-Status: No, score=-5.3 required=5.0 tests=BAYES_00,JMQ_SPF_NEUTRAL,KAM_DMARC_STATUS,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --vxOzx4JjWcK91pl3 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline On 11 Jan 2024 10:50, Neal Frager wrote: > + [case x"$withval" in use AS_CASE > + x/*) ;; > + *) > + with_tooldir= > + AC_MSG_WARN([argument to --with-tooldir must be an absolute path]) shouldn't this be AC_MSG_ERROR ? otherwise you're leaving it unset below. -mike --vxOzx4JjWcK91pl3 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEuQK1JxMl+JKsJRrUQWM7n+g39YEFAmWgDCIACgkQQWM7n+g3 9YGT7w//XekeAVrNJuaQzJ0FCOhfsKVPXjqrvFIOOFlQbnDO7N0GDOLjQBOSagCw l4NAwiOI6K5nlzxL77H3dbKrJYiXMGnHep3lAEvxpDsS7SJiVzIBrJY0PhmOxi7S J92162rej2ef+1S4nt39HZxS4kiUCZvSxY90x2R0T4WGGfIRJtcYLruOLAUt4PZf FDQXQJzAw9EPd/P4nSX9XoSaqMkWPz2wVd4tIgRXLKJNwqIX4K1uXQz6cLvDyf0A +xgwqmV4zeMs8hcfwX0gGrgp/fm+ASX/X/Th/mjAIZaiwE3xOTMv1U2HzPoEq57C nr+rymLGh/5VSvqJcXPL6xJo6W3JhWvLY5zcXma3QHjuylaKWQEPjDcgPqyz+dcx By+GLnhZsqn2KHoA/96e7qIi80uIJzrDaOJe6IFV1N0Dv7jQizr94HM5cDM/mpsw zcavH1cbI1vyspXxqsiBtFe3djSH4wWpFN4GX9S7g0d+bjdaxiUA7bolpqwI+sbe mvWsz+bI3CIYAZCgCjn2JnYMN84X8efxWOHBeQIuKAFWtEb3Bqh1wsCZQDJ9mBt3 ibGkzFrCLurUwyGh9iqJoaU73sRNnFfSW2iglefC/cwBCrErOs6I5vBSIqd8WJMR U9lWhuNMSxcYWD07of6YghOesspr14dq2BJWhYCCwiiGWOBXU6Q= =eMdK -----END PGP SIGNATURE----- --vxOzx4JjWcK91pl3--