From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 8BF373858C2A for ; Fri, 19 Jan 2024 12:55:12 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 8BF373858C2A Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 8BF373858C2A Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1705668914; cv=none; b=Dvn8zkBSvZRETaR0gsYrHbLr5d1hmG1z7ASAZiCSY6ce7Q0NufXY1Jv6YyDT21c3x32ZQbjz5oV7TDOziCCu6onRH5IIZRxSmFkq5HG0B5AaQ5+YdhSYDigGpR8cfVF5CCkea4eau8dzQgEGtIhDXWHUgr/p4qKG1IaN7p68iDs= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1705668914; c=relaxed/simple; bh=Txxs82vKvmeMZCsfZGjWN1Y2vkLz0s2fLnoK7gzzAj4=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=Z9Z0ZnVvSZO2zhOdvgRaXATGdqb3Nix3PWSeSselBITqXh0hHg7GugNYcCB8b0yhEs9iyEEVxPl7goiLtDU4jGbohwi99ckMR2ntTAovGrGsGB9LDCF9jlhcO6NvYhu1b32FeUbnOkTMlL9S6XoifK9d/9i5YNDZVTzkuHBbm6g= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1705668912; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type; bh=wGaYTEOpbgdzS20yqhzGbG0rTFJmj7oiCdA/d4wuxpQ=; b=fJedwuYve+VqlTGIp5236bOq2aTUDmOQp6Pb39IJMa5L6X44lrjuV/J4GhTUfMiCAUwF7I EJNt4nmbjB6ixiQdC87lkmI/pDA87U0jszaQg49dup3UNDXyPzy+faTNj2D315XWt5FhWg U75QZoBDQkuSiFuFXkqLUDkYG6H9kRY= Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-515-KKScDvpdM2iHuUCwOhDWYw-1; Fri, 19 Jan 2024 07:55:10 -0500 X-MC-Unique: KKScDvpdM2iHuUCwOhDWYw-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 1F3091C05137 for ; Fri, 19 Jan 2024 12:55:10 +0000 (UTC) Received: from calimero.vinschen.de (unknown [10.39.192.49]) by smtp.corp.redhat.com (Postfix) with ESMTPS id F3000200BC63 for ; Fri, 19 Jan 2024 12:55:09 +0000 (UTC) Received: by calimero.vinschen.de (Postfix, from userid 500) id A584BA8091C; Fri, 19 Jan 2024 13:55:08 +0100 (CET) Date: Fri, 19 Jan 2024 13:55:08 +0100 From: Corinna Vinschen To: newlib@sourceware.org Subject: -Wall Message-ID: Reply-To: newlib@sourceware.org Mail-Followup-To: newlib@sourceware.org MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.4 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Spam-Status: No, score=-6.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi folks, if you saw my today's pushes, you're aware that I only found a bug because I used -Wall. I fixed the bug and a few less crucial warnings. I did NOT fix the warnings in code we took verbatim from some BSDs, which often contain unused variables, or in some cases expressions which are deemed to profit from extra paranthesis, e. g. if (a >= 0 ^ b == 0) For that reason, I'd like to suggest to add -Wall by default to the build flags for newlib, just as it is already for ages in the Cygwin tree. Anybody having a strong opinion, pro or contra? Corinna