From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.gentoo.org (woodpecker.gentoo.org [140.211.166.183]) by sourceware.org (Postfix) with ESMTP id DEBD93858C98 for ; Fri, 19 Jan 2024 15:38:41 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org DEBD93858C98 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gentoo.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gentoo.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org DEBD93858C98 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=140.211.166.183 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1705678724; cv=none; b=TceYgEy4vZxNC5wW9JTwixiWbBifWU0sHLQtT/mTyhN1SLEL8U7MCm4Jfc4/At6JlPBwYh7loM+qAEwErifQTr2ysPUql5412ACIrLfAUiVaBtcc3LwuNTrUIbkR7tHXrdknuszegEMhGIDg3Pq2loFVPhK6/RdRyzuvsZzM960= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1705678724; c=relaxed/simple; bh=kqUtCswLjfEro9OK/oSGqxzyV6jcr9NBx4gZSKjAoBY=; h=Date:From:To:Subject:Message-ID:MIME-Version; b=YVTSPwigSeUNtqvVIoxqvD0HJOLOKTfYbEl4/iisF826L7tvDXX3hiPzH/JuLxGolcJRA5AWqCqlxfOR3FyoWD562ILLFY9qDAl7MfmSpq21cRTYUAPe5is51qm1VnLj/RgBR71uCOFj+965DVgxbls8NCR/mz9f8NZjFXgME88= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by smtp.gentoo.org (Postfix, from userid 559) id 53C2434336A; Fri, 19 Jan 2024 15:38:41 +0000 (UTC) Date: Fri, 19 Jan 2024 10:38:41 -0500 From: Mike Frysinger To: newlib@sourceware.org Subject: Re: -Wall Message-ID: References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="JP/MqA+iF/qZo5tK" Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-5.3 required=5.0 tests=BAYES_00,JMQ_SPF_NEUTRAL,KAM_DMARC_STATUS,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --JP/MqA+iF/qZo5tK Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 19 Jan 2024 13:55, Corinna Vinschen wrote: > if you saw my today's pushes, you're aware that I only found a bug > because I used -Wall. I fixed the bug and a few less crucial warnings. >=20 > I did NOT fix the warnings in code we took verbatim from some BSDs, > which often contain unused variables, or in some cases expressions which > are deemed to profit from extra paranthesis, e. g. >=20 > if (a >=3D 0 ^ b =3D=3D 0) >=20 > For that reason, I'd like to suggest to add -Wall by default to the > build flags for newlib, just as it is already for ages in the Cygwin > tree. >=20 > Anybody having a strong opinion, pro or contra? enabling -Wall by default sounds fine. if you wanted to include any -Werro= r, that would require more effort/tooling like putting it all behind a new flag like --enable-werror. -mike --JP/MqA+iF/qZo5tK Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEuQK1JxMl+JKsJRrUQWM7n+g39YEFAmWql4EACgkQQWM7n+g3 9YEHFQ//T4ANdN0F0/ap2w16KhgRTuKqeIvRnprSopzg1VtFYZTGi4m2q+UtR9iK +I9V/P0NR6U31QuYaqqCWJnUdWwIKIwsQmKjzl3OJZTCo4z68lBDcJziQm5uRRvH /+B6pOI8wbOP0qJ3QsbcauEsNDjymG511nqiz+H5vjJZcozd6DGrNNpHDKOE87VK mp7f9lILp5CbbJBQdHRRHvKRcy0fYVT2Tz3NNtKcuoqmstAnODZWXrpQ0tSJG9eA b5qKQEkDK2ZB/Z82/A3LUCe20y5DD9SoCL8Ya7vrsjKtWcDErSkK/hICtEmx4s45 V5hzCg1RapCUG3Rw8e/E/+wXiA7/0DVxWzRRPI2fIMuL2+03gwqEHqlnQBA968WQ 7cduxMvHN02T2I/EHC+QFHzfYjbifXKrRnSN8gWR7057soI5UcjIgbnx+gnleZgV jPf3GDOUOHu6jz/Dqtu6OoDp4MeSXVGd5onbzCaA9YOFOpkRnEzYQrlJOCk2F+TN eX7nBmUsKwYrLpAV3DZuCGEGMcwuNRutjluVi10DHTD3qcy01PRRHAnbC6Q8t4jT /o7UN39DtyGK8AZebjr+XJj/mVpRXtxdvEknPsnzZU5xXFBNNH2J1WxTl8wSuXfT urtuYYXmncPDL6W03f38fF0F82wDkmAq7MSm7OSvJs6g2FxRxrU= =G2w+ -----END PGP SIGNATURE----- --JP/MqA+iF/qZo5tK--