From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 1388E3858424 for ; Mon, 5 Feb 2024 09:39:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1388E3858424 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 1388E3858424 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1707125992; cv=none; b=N6CSU9v9r2WCzCLyp8OJ5btX772Z5nqaSnBo/FC1oPPHAS6qk/zsOCCiMaHHRUeZB+1mYYXyK+BSzjXo6lDAoWS3vDFe5/tr/RlthzKBOCdEJ2cbxGVrZCjx9As4VvBMCR1l/euxvH16huaEv7XgIxuBr70/wMkHX2oohhO414Q= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1707125992; c=relaxed/simple; bh=+treCyLRJj3EI7N5pwJpmyt94dGEQj5Hl/eJKw5/KXU=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=WHHGfbn48ACh3ruf2io715eorPKUE6wlBkeE6OI5rQK2Trs5ApP5JppLM5DOVk/2c08eBv//SjSzetIiS25Rbzc8l7NXYbXeqssZRJGqt9cZxfWeyO5oDOhUnEWsCpqGpCTRwmgXT0FkP0C1YOaUQ+NAIWLbP2Loa0X4pNqStsw= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1707125990; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=Llua+2faYJvnsLAM20eXvc+4Om5MhG+8d4VQAvPRy6Y=; b=TD4vczZLFG0r0mOgFwvhK1+piU9Dk3PquS2+GzyUJ88xF3f8fqnsr39SpbdCV4Z5kku1/I XcnEsYfzamu9LUMIlXbhw0lg+4hy3nXes2TFpXuyk8wapOc6MvkeisBirtdOHiVY8SemhT MSzlQ0m1Oq0UIqQriwEooCbLTqAsd3k= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-544-DTt_jPXEMNujlDpXZdH2uA-1; Mon, 05 Feb 2024 04:39:49 -0500 X-MC-Unique: DTt_jPXEMNujlDpXZdH2uA-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 4E910185A786 for ; Mon, 5 Feb 2024 09:39:49 +0000 (UTC) Received: from calimero.vinschen.de (unknown [10.39.192.85]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 2DB361C060B1 for ; Mon, 5 Feb 2024 09:39:49 +0000 (UTC) Received: by calimero.vinschen.de (Postfix, from userid 500) id D6224A80A5D; Mon, 5 Feb 2024 10:39:47 +0100 (CET) Date: Mon, 5 Feb 2024 10:39:47 +0100 From: Corinna Vinschen To: newlib@sourceware.org Subject: Re: Problem with recent change to getlocalename_l Message-ID: Reply-To: newlib@sourceware.org Mail-Followup-To: newlib@sourceware.org References: MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.7 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Feb 4 19:39, Jeff Law wrote: > On 2/4/24 12:34, Dimitar Dimitrov wrote: > > On Thu, Feb 01, 2024 at 08:44:32PM +0100, Corinna Vinschen wrote: > > > On Feb 1 20:11, Corinna Vinschen wrote: > > > > No, wait. > > > > > > > > On Feb 1 20:00, Corinna Vinschen wrote: > > > > > Given that this new functionality needs a 32 byte buffer, and given that > > > > > _REENT_SMALL targets are... well... small, I made the new buffer > > > > > optional via `#ifdef _MB_CAPABLE' in struct _misc_reent, which only used > > > > > by _REENT_SMALL targets. > > > > > > > > > > Apparently I missed to take the _REENT_CHECK_MISC expression into account. > > > > > AFAICS the culprit is the _REENT_INIT_MISC macro now. > > > > > > > > > > Can you please check if this change fixes the problem? > > > > > > > > Try this one instead, please: > > > > > > Sorry, I suddenly realized that I screwed up the name of the new member > > > as well. Sigh. > > > > > > Please try this one, it's also much simpler: > [ ... ] > > > > > > > > > Hi, > > > > This fixes the build for pru-unknown-elf, and there are no regressions > > when running the GCC and newlib testsuites. > Yea, that worked for me as well. All the usual crosses built and passed > with the exception of rl78, but I don't think that's a newlib problem, it's > more likely a compiler issue. > > Thanks for the testing Corinna's patch too! > > jeff Thanks for testing guys, I pushed the patch. Corinna