From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id B5ED5385780D for ; Wed, 13 Mar 2024 17:06:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B5ED5385780D Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org B5ED5385780D Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1710349613; cv=none; b=C0RVrDLIbT7oTYUpJ/30UeB1JCT6zX8CEi6dfbjK6gly3lfYRsxJfBCSNbQpOUVr8kQDg7R8eIcX4xavfF4qhDqUn5jezX/42/RKD/wB8oClCcnQj0rIeFTqRG6GbjIYu8MeNDIHjlMpsbv2EDQndkT93/tFFdog3dVEgqkIKVM= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1710349613; c=relaxed/simple; bh=YC0TCwpfzwvpT1gvMgUHk1Ea3aHEJLAw/N4To23tNuc=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=AEpVOhmXWGF6nPDZkYEOSgSeCwyi/jQp3nkCM6GoulEah4ItXjXvWlQD879J9zA+A2ZhFXq6EuuphesRvYVwmiA60Ykhxi5fRK6pvrHiE9D/ro27mNqWbx39zGZj87gDsIZYu7riTEoGVrAxDAEq49uS7wZCRO8hnw+Wnlzjqdk= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1710349611; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=APwDZsdFLOv5m4oI1TYMIzBqoL5nZ4lMO8fE1nzMfnk=; b=S1dbhKXBYDgIy/aFmRGZGmONNAwwqqLqmti/xWKeJktYab8elSJECKGj8n94iH2mhuROqu zxA7LcArufNQptBL6m1zyUBNGxXLanxd7yV9VK+IRRrinYYfPgWpmnZReFD43nan+jwrNm WtPpiacIYQXJs8f8fhv5I+P8iG1Cnf8= Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-626-hFdNdLq3N8S4d32d81mGkg-1; Wed, 13 Mar 2024 13:06:47 -0400 X-MC-Unique: hFdNdLq3N8S4d32d81mGkg-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 6B3461C01702; Wed, 13 Mar 2024 17:06:47 +0000 (UTC) Received: from calimero.vinschen.de (unknown [10.39.192.16]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 4910B200AFA2; Wed, 13 Mar 2024 17:06:47 +0000 (UTC) Received: by calimero.vinschen.de (Postfix, from userid 500) id 204B5A80706; Wed, 13 Mar 2024 18:06:46 +0100 (CET) Date: Wed, 13 Mar 2024 18:06:46 +0100 From: Corinna Vinschen To: Joel Sherrill Cc: newlib@sourceware.org, Jon Turney , Chris Johns Subject: Re: Include FD_SETSIZE on RTEMS to 256 Message-ID: Reply-To: newlib@sourceware.org Mail-Followup-To: Joel Sherrill , newlib@sourceware.org, Jon Turney , Chris Johns References: <9514182a-f513-4296-8178-43b5274abb7f@dronecode.org.uk> MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.4 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-5.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,KAM_NUMSUBJECT,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Mar 13 11:33, Joel Sherrill wrote: > On Wed, Mar 13, 2024 at 11:03 AM Joel Sherrill wrote: > > > > > > > On Wed, Mar 13, 2024 at 10:02 AM Corinna Vinschen > > wrote: > > > >> On Mar 13 09:35, Joel Sherrill wrote: > >> > On Wed, Mar 13, 2024 at 9:21 AM Jon Turney >> > > >> > wrote: > >> > > >> > > On 28/02/2024 23:02, Joel Sherrill wrote: > >> > > > Hi > >> > > > > >> > > > The attached patch changes FD_SETSIZE from 64 to 256 for RTEMS. > >> > > > > >> > > > Is it OK to apply? > >> > > > > >> > > > >> > > This uses the preprocessor directive '#elifdef', > >> > > > >> > > It seems like support for that was added in gcc 12. > >> > > > >> > > >> > Good catch. Unfortunately, I just pushed the posted patch just before > >> your > >> > email arrived. > >> > > >> > I have posted a small patch to change this to #elif defined(__rtems__). > >> If > >> > someone acks it, I will push it quickly to minimize who might be > >> impacted. > >> > >> You sent the wrong patch apparently. However, if your patch just > >> changes #elifdef X to #elif defined (X), then test it with a pre-12 > >> gcc and then push it. Soon. > >> > > > > Sorry. I am building a gcc8 toolchain now to verify the change. Hopefully, > > it will not be too much longer. > > > > Correction pushed and tested with gcc8 and a test program. > > --joel Thanks! Corinna