From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 01A1D3858403 for ; Mon, 25 Mar 2024 10:35:28 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 01A1D3858403 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 01A1D3858403 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1711362939; cv=none; b=MLEZgly8iJ5M2yQMD9haDkpnPriOI7Gwz3gAkoZ9vVNM5eaK3FTaOFJJEiH3vNo65UJj+fy4lxX9yNygP/LWJJ5B/R7qusR+9roLLlIJ6YNJqgy4FmEL55xsJVKBjuo4z6j6qJ7o6MyAV63ahjlBhpompUmClzM1NcM3+7KH+rI= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1711362939; c=relaxed/simple; bh=nYDIcoJqfEsxCtvY3pkylpcV0PIQeC9meZGgglQSg6w=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=hH+inEy6q47xJz2Tnr5+QmaDmlCMaXFTyff9xmZCEz4U2pitJul2O4FhDAycUXB819bCWrL5eiQWTYJSR1uR/Ye/phPcTF9KWmxWXQW3BjJuOtGaXYygDux5JAkIJJ8ph973PE/WDqnZvazuHwrOK2nOwZYA62YXjnq3GGVW00s= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1711362928; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=2a9HrASxn0vyOIvYBXsQuIF8okHZBjnPN500GqKoOxY=; b=PVjZIJzSNjVKl8RSeW02pVuxQtMUhJCHy5Tyl1Ym5sYGl7L4h9wcN2MqDIeWJMca2E1dqk 0TLZ2EEXFp8vJ05k2KCMFogOUBSMp/kXAhYrcTZtssZP5NNbZJ9id616IgcM6G2IyYbtvb C2zZ7kwfv1aThcBTqaJGq9MySr8+dV8= Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-107-Y86cQtKiNSm3j7Y7Ov5I6g-1; Mon, 25 Mar 2024 06:35:25 -0400 X-MC-Unique: Y86cQtKiNSm3j7Y7Ov5I6g-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id DDF2E383DCD1; Mon, 25 Mar 2024 10:35:24 +0000 (UTC) Received: from calimero.vinschen.de (unknown [10.39.192.6]) by smtp.corp.redhat.com (Postfix) with ESMTPS id BC55F492BD0; Mon, 25 Mar 2024 10:35:24 +0000 (UTC) Received: by calimero.vinschen.de (Postfix, from userid 500) id 861FCA80B9E; Mon, 25 Mar 2024 11:35:19 +0100 (CET) Date: Mon, 25 Mar 2024 11:35:19 +0100 From: Corinna Vinschen To: Andrew Stubbs Cc: newlib@sourceware.org Subject: Re: [PATCH] amdgcn: Implement proper locks Message-ID: Reply-To: newlib@sourceware.org Mail-Followup-To: Andrew Stubbs , newlib@sourceware.org References: <20240322145330.761851-1-ams@baylibre.com> MIME-Version: 1.0 In-Reply-To: <20240322145330.761851-1-ams@baylibre.com> X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.10 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Spam-Status: No, score=-5.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Mar 22 14:53, Andrew Stubbs wrote: > This should prevent printf output from multiple threads getting garbled. > > I don't know why IO ever worked properly -- probably it was always a bit > broken -- but the GFX11 devices have a different cache architecture and > trying to print from many threads at once corrupted the FILE buffers. > --- > newlib/Makefile.in | 24 ++- > newlib/libc/sys/amdgcn/Makefile.inc | 3 +- > newlib/libc/sys/amdgcn/include/sys/lock.h | 39 +++++ > newlib/libc/sys/amdgcn/lock.c | 187 ++++++++++++++++++++++ > 4 files changed, 250 insertions(+), 3 deletions(-) > create mode 100644 newlib/libc/sys/amdgcn/include/sys/lock.h > create mode 100644 newlib/libc/sys/amdgcn/lock.c Pushed. Thanks, Corinna