From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 3BB9A3858CDB for ; Fri, 12 Apr 2024 09:45:15 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3BB9A3858CDB Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 3BB9A3858CDB Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712915117; cv=none; b=FXHclqsgH0jYRpKlmeJwnUOqWLh/L+O9oBYof5VawDWXUORkAk4LPa0Qfuv9lCoJ7HHOmNUoeavyIvCDQ7DDkaBZFvlu2zNGIecaXAxh4Ohd0zEJ7c19kSpdVZf8GOWVA17hESqvaWmV7OB7Bs1/YU92Nyag7xaqRWJ+uxS7bV4= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712915117; c=relaxed/simple; bh=OGnzNyyB2qPw4QxjObx6CP/niidrXTcEV2sozkHjG/s=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=U7bd8BbEy+T9VPSeQr6CXQxJmNknjrMI9wOgKTztkr4vA9X1MFdxg2HlPr4FN/7sIfAOhRr1UE94iGouFLvhQltBYd1olUGBKlhmp6mUAjUt4vgx3/xRTsgXazd9g8MfOVaS1w6sKciG8sUROPUlgL0CyycKc2Km+wPSf/SLjJk= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1712915114; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=skT2R6XB6XBx0jim3Z5SaL2E2CP3M6lcD5TCf3jIbdM=; b=IsjKMhtgGyP7lWrOBGRI12OcEAlDxnY0KShXVcEu59EpsQIZLQZsFsLRPJ314LailrN9By zXR93aFKOcNmpqscqmMizjV3yPzZYCq/BiIXV3DuXuuRu9Cy7A1PsuxMJ+XpN8WRuVf+7u H8Sc0WkNO9JuppcuJQ261MANeaw1fNU= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-247-04DuuEgIPSiS1rFEDjerPw-1; Fri, 12 Apr 2024 05:45:13 -0400 X-MC-Unique: 04DuuEgIPSiS1rFEDjerPw-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 043D3104D982; Fri, 12 Apr 2024 09:45:13 +0000 (UTC) Received: from calimero.vinschen.de (unknown [10.39.192.6]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D69D62166B31; Fri, 12 Apr 2024 09:45:12 +0000 (UTC) Received: by calimero.vinschen.de (Postfix, from userid 500) id 62D08A80A5D; Fri, 12 Apr 2024 11:45:07 +0200 (CEST) Date: Fri, 12 Apr 2024 11:45:07 +0200 From: Corinna Vinschen To: Bernd Edlinger Cc: newlib@sourceware.org Subject: Re: [PATCH] libgloss: riscv: Fix envp parameter for main Message-ID: Reply-To: newlib@sourceware.org Mail-Followup-To: Bernd Edlinger , newlib@sourceware.org References: MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.6 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Spam-Status: No, score=-11.9 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Apr 11 14:57, Bernd Edlinger wrote: > The envp paramter is currently NULL when crt0.S calls main. > With this patch the envp parameter should now be set correctly. > Tested with riscv32 and riscv64: both gdb/sim and qemu do work. > --- > libgloss/riscv/crt0.S | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/libgloss/riscv/crt0.S b/libgloss/riscv/crt0.S > index f1c5419a5..54443e412 100644 > --- a/libgloss/riscv/crt0.S > +++ b/libgloss/riscv/crt0.S > @@ -61,7 +61,9 @@ _start: > > lw a0, 0(sp) # a0 = argc > addi a1, sp, __SIZEOF_POINTER__ # a1 = argv > - li a2, 0 # a2 = envp = NULL > + slli a2, a0, 1 + __SIZEOF_POINTER__ >> 2 > + addi a2, a2, __SIZEOF_POINTER__ > + add a2, a2, a1 # a2 = envp > call main > tail exit > .size _start, .-_start > -- > 2.25.1 Pushed. Thanks, Corinna