From: Chris Johns <chrisj@rtems.org>
To: newlib@sourceware.org
Subject: Re: [PATCH] Reclaim _REENT_MP_P5S in _reclaim_reent
Date: Fri, 17 Nov 2023 08:17:25 +1100 [thread overview]
Message-ID: <aa539eeb-a079-4a7e-a8f2-064e5c86cf25@rtems.org> (raw)
In-Reply-To: <ZVXdqnpOEKrBv9ir@calimero.vinschen.de>
On 16/11/2023 8:15 pm, Corinna Vinschen wrote:
> On Nov 16 12:12, chrisj@rtems.org wrote:
>> From: Chris Johns <chrisj@rtems.org>
>>
>> The change fixes a memory leak in threads that clean up using
>> _reclaim_reent.
>>
>> RTEMS: Closes #4967
>> ---
>> newlib/libc/reent/reent.c | 11 +++++++++++
>> 1 file changed, 11 insertions(+)
>>
>> diff --git a/newlib/libc/reent/reent.c b/newlib/libc/reent/reent.c
>> index db80ca06e..6bb271b9a 100644
>> --- a/newlib/libc/reent/reent.c
>> +++ b/newlib/libc/reent/reent.c
>> @@ -59,6 +59,17 @@ _reclaim_reent (struct _reent *ptr)
>> }
>> if (_REENT_MP_RESULT(ptr))
>> _free_r (ptr, _REENT_MP_RESULT(ptr));
>> + if (_REENT_MP_P5S(ptr))
>> + {
>> + struct _Bigint *thisone, *nextone;
>> + nextone = _REENT_MP_P5S(ptr);
>> + while (nextone)
>> + {
>> + thisone = nextone;
>> + nextone = nextone->_next;
>> + _free_r (ptr, thisone);
>> + }
>> + }
>
> The p5s data is allocated using Balloc, so the pointers are in freelist
> and should already be free'd at this point, starting at line 42.
Yes however P5S blocks allocated by Balloc via i2b are not passed to Bfree.
> Please explain what happens and why free'ing the freelist is not
> sufficient in this case, preferredly as part of the commit message.
Yes good idea. How about:
The _REENT_MP_P5S blocks are allocated using Balloc via i2b and linked in the
pow5mult call. As a result these blocks are not on the freelist managed by the
Bfree call. This change fixes a memory leak in threads that clean up using
_reclaim_reent.
Chris
next prev parent reply other threads:[~2023-11-16 21:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-16 1:12 chrisj
2023-11-16 9:15 ` Corinna Vinschen
2023-11-16 21:17 ` Chris Johns [this message]
2023-11-17 12:08 ` Corinna Vinschen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aa539eeb-a079-4a7e-a8f2-064e5c86cf25@rtems.org \
--to=chrisj@rtems.org \
--cc=newlib@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).