From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 44909 invoked by alias); 6 Feb 2017 14:39:07 -0000 Mailing-List: contact newlib-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: newlib-owner@sourceware.org Received: (qmail 44819 invoked by uid 89); 6 Feb 2017 14:39:07 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=no version=3.3.2 spammy=569, Hx-spam-relays-external:209.85.192.194, H*RU:209.85.192.194, Hx-languages-length:1084 X-HELO: mail-pf0-f194.google.com Received: from mail-pf0-f194.google.com (HELO mail-pf0-f194.google.com) (209.85.192.194) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 06 Feb 2017 14:39:03 +0000 Received: by mail-pf0-f194.google.com with SMTP id f144so7039906pfa.2 for ; Mon, 06 Feb 2017 06:39:03 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:in-reply-to:references; bh=WGjSMkzRwK1BK8MYWlx+gr3Q7FUCEDVVR0Br2jFYDEc=; b=lc3/65KGWe5jtbzifmATqLyHIvzGtWAd29xSe6Jw//elsLvJK69i98GIEEH5357bHL M9UyaYuBIP+mjo9HKIKNjXJBYc0iGigxLGzW57JSu8e4CpmL19I9IXGBiBtWX1CAMWGd p/ewrpccbJlZBBPBmYdwMBf7Wyw4YOmiA8sNt+Z64eCHRsflDclsTxbbsA6qQNq92WJW cl7BINqjPX4nRulYzH4kdOgZSMj4847dbzQ+M4QrfwOpJWULEFlKElv7SZBwn19dZY1m BIUejxOP0c7fOFMre89DHHBHJ5meY0FK8d0BA6U4CSyhvWkzuaNnuJ/GSWym5VUoxXf+ Yatw== X-Gm-Message-State: AIkVDXIaq5QJDmoWXqSiv7t0BnainDhNYgnr159h0UYIFHi3ZI4ME3VtcjtEU0MIp5oZZg== X-Received: by 10.98.194.22 with SMTP id l22mr13421808pfg.178.1486391941912; Mon, 06 Feb 2017 06:39:01 -0800 (PST) Received: from localhost (z192.124-44-186.ppp.wakwak.ne.jp. [124.44.186.192]) by smtp.gmail.com with ESMTPSA id z70sm3384264pff.26.2017.02.06.06.39.00 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 06 Feb 2017 06:39:01 -0800 (PST) From: Stafford Horne To: newlib@sourceware.org Cc: openrisc@lists.librecores.org, stefan.wallentowitz@posteo.de, Stafford Horne Subject: [PATCH 3/3] libgloss: Remove duplicate definition of environ Date: Mon, 06 Feb 2017 14:39:00 -0000 Message-Id: In-Reply-To: References: In-Reply-To: References: X-SW-Source: 2017/txt/msg00131.txt.bz2 Environ is defined in libgloss and libc: - libgloss/or1k/syscalls.c - libc/stdlib/environ.c When linking we sometimes get errors: or1k-elf-g++ test.o -mnewlib -mboard=or1ksim -lm -o test /opt/shorne/software/or1k/lib/gcc/or1k-elf/5.3.0/../../../../or1k-elf/lib/libor1k.a(syscalls.o):(.data+0x0): multiple definition of `environ' /opt/shorne/software/or1k/lib/gcc/or1k-elf/5.3.0/../../../../or1k-elf/lib/libc.a(lib_a-environ.o):(.data+0x0): first defined here collect2: error: ld returned 1 exit status This doesnt happen after the fix. Basic things build fine too. --- libgloss/or1k/syscalls.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/libgloss/or1k/syscalls.c b/libgloss/or1k/syscalls.c index 3e2ad22..92bff49 100644 --- a/libgloss/or1k/syscalls.c +++ b/libgloss/or1k/syscalls.c @@ -56,9 +56,6 @@ _close_r(struct _reent *reent, int fildes) return -1; } -char *__env[1] = { 0 }; -char **environ = __env; - int _execve_r(struct _reent *reent, const char *name, char * const *argv, char * const *env) -- 2.9.3