From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by sourceware.org (Postfix) with ESMTP id 55FC43858CDA for ; Mon, 19 Dec 2022 11:23:19 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 55FC43858CDA Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=foss.arm.com Authentication-Results: sourceware.org; spf=none smtp.mailfrom=foss.arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id DACB8FEC; Mon, 19 Dec 2022 03:23:59 -0800 (PST) Received: from [10.57.11.95] (unknown [10.57.11.95]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 787033F703; Mon, 19 Dec 2022 03:23:18 -0800 (PST) Message-ID: Date: Mon, 19 Dec 2022 11:23:17 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH] libc: arm: setjmp.S code cleanup Content-Language: en-GB To: "Victor L. Do Nascimento" , newlib@sourceware.org References: From: Richard Earnshaw In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3496.2 required=5.0 tests=BAYES_00,GIT_PATCH_0,KAM_DMARC_STATUS,KAM_LAZY_DOMAIN_SECURITY,NICE_REPLY_A,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 14/12/2022 16:46, Victor L. Do Nascimento wrote: > The code for setjmp and longjmp contains unconditionally-disabled > legacy FPA code. > > Given the code is not used by any targets, remove the code. > --- > newlib/libc/machine/arm/setjmp.S | 12 ------------ > 1 file changed, 12 deletions(-) > > diff --git a/newlib/libc/machine/arm/setjmp.S b/newlib/libc/machine/arm/setjmp.S > index 4cf0a8e3f..d814afea8 100644 > --- a/newlib/libc/machine/arm/setjmp.S > +++ b/newlib/libc/machine/arm/setjmp.S > @@ -182,12 +182,6 @@ SYM (\name): > vstm r0, { d8-d15 } > #endif > > -#if 0 /* Simulator does not cope with FP instructions yet. */ > -#ifndef __SOFTFP__ > - /* Save the floating point registers. */ > - sfmea f4, 4, [a1] > -#endif > -#endif > /* When setting up the jump buffer return 0. */ > mov r0, #0 > > @@ -212,12 +206,6 @@ SYM (\name): > vldm r0, { d8-d15 } > #endif > > -#if 0 /* Simulator does not cope with FP instructions yet. */ > -#ifndef __SOFTFP__ > - /* Restore floating point registers as well. */ > - lfmfd f4, 4, [a1] > -#endif > -#endif > /* Put the return value into the integer result register. > But if it is zero then return 1 instead. */ > movs r0, r1 Thanks, pushed. R.