From: Sebastian Huber <sebastian.huber@embedded-brains.de>
To: newlib@sourceware.org
Subject: Re: [PATCH 08/11] Add stdio atexit handler
Date: Wed, 11 May 2022 19:51:07 +0200 [thread overview]
Message-ID: <acc307cc-05b0-5508-feb0-c771e1b29de7@embedded-brains.de> (raw)
In-Reply-To: <YnvqOF/YkJ7MNmCz@calimero.vinschen.de>
On 11/05/2022 18:54, Corinna Vinschen wrote:
> On May 11 17:23, Corinna Vinschen wrote:
>> On May 10 10:09, Matthew Joyce wrote:
>>> From: Matt Joyce<matthew.joyce@embedded-brains.de>
>>>
>>> Add a dedicated stdio atexit handler to avoid using _GLOBAL_REENT in exit().
>> The idea is ok, I would just prefer to use another name. The reason is
>> that an unsuspecting user could assume that this function actually gets
>> added to the atexit functions. What about stdio_exit_handler()?
> Btw., this produces a build problem in Cygwin:
>
> winsup/cygwin/signal.cc:179:1: error: conflicting declaration of C function ‘unsigned int usleep(useconds_t)’
> 179 | usleep (useconds_t useconds)
> | ^~~~~~
> In file included from libc/include/unistd.h:4,
> from winsup/cygwin/../../newlib/libc/stdio/local.h:29,
> from winsup/cygwin/signal.cc:25:
> libc/include/sys/unistd.h:240:9: note: previous declaration ‘int usleep(useconds_t)’
> 240 | int usleep (useconds_t __useconds);
> | ^~~~~~
Should this be fixed in signal.cc? usleep() should return int.
--
embedded brains GmbH
Herr Sebastian HUBER
Dornierstr. 4
82178 Puchheim
Germany
email: sebastian.huber@embedded-brains.de
phone: +49-89-18 94 741 - 16
fax: +49-89-18 94 741 - 08
Registergericht: Amtsgericht München
Registernummer: HRB 157899
Vertretungsberechtigte Geschäftsführer: Peter Rasmussen, Thomas Dörfler
Unsere Datenschutzerklärung finden Sie hier:
https://embedded-brains.de/datenschutzerklaerung/
next prev parent reply other threads:[~2022-05-11 17:51 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-10 8:09 [PATCH 00/11] Decouple global file object list from _GLOBAL_REENT Matthew Joyce
2022-05-10 8:09 ` [PATCH 01/11] Remove duplicate stdio initializations Matthew Joyce
2022-05-10 8:09 ` [PATCH 02/11] Remove duplicate sglue initializations Matthew Joyce
2022-05-10 8:09 ` [PATCH 03/11] Declare global __sf[] only once Matthew Joyce
2022-05-10 8:09 ` [PATCH 04/11] Add two __sglue initialization macros Matthew Joyce
2022-05-10 8:09 ` [PATCH 05/11] Remove __sinit_locks / __sinit_recursive_mutex Matthew Joyce
2022-05-10 8:09 ` [PATCH 06/11] Move __sglue initializations to __sfp() Matthew Joyce
2022-05-10 8:09 ` [PATCH 07/11] Add CLEANUP_FILE define Matthew Joyce
2022-05-10 8:09 ` [PATCH 08/11] Add stdio atexit handler Matthew Joyce
2022-05-11 15:23 ` Corinna Vinschen
2022-05-11 16:54 ` Corinna Vinschen
2022-05-11 17:51 ` Sebastian Huber [this message]
2022-05-11 17:51 ` Sebastian Huber
2022-05-10 8:09 ` [PATCH 09/11] stdio: Replace _fwalk_reent() with _fwalk_sglue() Matthew Joyce
2022-05-11 15:56 ` Corinna Vinschen
2022-05-11 17:55 ` Sebastian Huber
2022-05-12 7:59 ` Corinna Vinschen
2022-05-10 8:09 ` [PATCH 10/11] Add global __sglue object for all configurations Matthew Joyce
2022-05-10 8:09 ` [PATCH 11/11] Remove __sglue member for one configuration Matthew Joyce
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=acc307cc-05b0-5508-feb0-c771e1b29de7@embedded-brains.de \
--to=sebastian.huber@embedded-brains.de \
--cc=newlib@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).