From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dedi548.your-server.de (dedi548.your-server.de [85.10.215.148]) by sourceware.org (Postfix) with ESMTPS id 187343858016 for ; Wed, 11 May 2022 17:51:12 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 187343858016 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=embedded-brains.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=embedded-brains.de Received: from sslproxy06.your-server.de ([78.46.172.3]) by dedi548.your-server.de with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1noqUP-000Ovw-PS for newlib@sourceware.org; Wed, 11 May 2022 19:51:10 +0200 Received: from [82.100.198.138] (helo=mail.embedded-brains.de) by sslproxy06.your-server.de with esmtpsa (TLSv1.3:TLS_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1noqUP-0007Ro-Tt for newlib@sourceware.org; Wed, 11 May 2022 19:51:09 +0200 Received: from localhost (localhost [127.0.0.1]) by mail.embedded-brains.de (Postfix) with ESMTP id 9D1EB4800F4 for ; Wed, 11 May 2022 19:51:09 +0200 (CEST) Received: from mail.embedded-brains.de ([127.0.0.1]) by localhost (zimbra.eb.localhost [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id PsGSVv2WNpif for ; Wed, 11 May 2022 19:51:09 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by mail.embedded-brains.de (Postfix) with ESMTP id 4DCE248017C for ; Wed, 11 May 2022 19:51:09 +0200 (CEST) X-Virus-Scanned: amavisd-new at zimbra.eb.localhost Received: from mail.embedded-brains.de ([127.0.0.1]) by localhost (zimbra.eb.localhost [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id JV8R7ZAnIOpi for ; Wed, 11 May 2022 19:51:09 +0200 (CEST) Received: from [10.10.171.14] (unknown [10.10.171.14]) by mail.embedded-brains.de (Postfix) with ESMTPSA id 21B404800F4 for ; Wed, 11 May 2022 19:51:09 +0200 (CEST) Message-ID: Date: Wed, 11 May 2022 19:51:07 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [PATCH 08/11] Add stdio atexit handler Content-Language: en-US To: newlib@sourceware.org References: <20220510080927.28839-1-matthew.joyce@embedded-brains.de> <20220510080927.28839-9-matthew.joyce@embedded-brains.de> From: Sebastian Huber In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Authenticated-Sender: smtp-embedded@poldinet.de X-Virus-Scanned: Clear (ClamAV 0.103.5/26538/Wed May 11 10:06:03 2022) X-Spam-Status: No, score=-5.5 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, NICE_REPLY_A, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: newlib@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Newlib mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 11 May 2022 17:51:13 -0000 On 11/05/2022 18:54, Corinna Vinschen wrote: > On May 11 17:23, Corinna Vinschen wrote: >> On May 10 10:09, Matthew Joyce wrote: >>> From: Matt Joyce >>> >>> Add a dedicated stdio atexit handler to avoid using _GLOBAL_REENT in = exit(). >> The idea is ok, I would just prefer to use another name. The reason is >> that an unsuspecting user could assume that this function actually get= s >> added to the atexit functions. What about stdio_exit_handler()? > Btw., this produces a build problem in Cygwin: >=20 > winsup/cygwin/signal.cc:179:1: error: conflicting declaration of C func= tion =E2=80=98unsigned int usleep(useconds_t)=E2=80=99 > 179 | usleep (useconds_t useconds) > | ^~~~~~ > In file included from libc/include/unistd.h:4, > from winsup/cygwin/../../newlib/libc/stdio/local.h:29= , > from winsup/cygwin/signal.cc:25: > libc/include/sys/unistd.h:240:9: note: previous declaration =E2=80=98in= t usleep(useconds_t)=E2=80=99 > 240 | int usleep (useconds_t __useconds); > | ^~~~~~ Should this be fixed in signal.cc? usleep() should return int. --=20 embedded brains GmbH Herr Sebastian HUBER Dornierstr. 4 82178 Puchheim Germany email: sebastian.huber@embedded-brains.de phone: +49-89-18 94 741 - 16 fax: +49-89-18 94 741 - 08 Registergericht: Amtsgericht M=C3=BCnchen Registernummer: HRB 157899 Vertretungsberechtigte Gesch=C3=A4ftsf=C3=BChrer: Peter Rasmussen, Thomas= D=C3=B6rfler Unsere Datenschutzerkl=C3=A4rung finden Sie hier: https://embedded-brains.de/datenschutzerklaerung/