From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gtd-gmbh.de (mail.gtd.eu [46.24.46.35]) by sourceware.org (Postfix) with ESMTPS id 22C563858D20 for ; Thu, 13 Apr 2023 14:41:52 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 22C563858D20 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=gtd-gmbh.de Authentication-Results: sourceware.org; spf=none smtp.mailfrom=gtd-gmbh.de DKIM-Signature: v=1; a=rsa-sha256; c=simple; d=gtd-gmbh.de; s=nk2048220908; t=1681396766; x=1682001566; i=andoni.arregui@gtd-gmbh.de; q=dns/txt; h=Message-ID:Subject: From:Reply-To:To:Cc:Date:In-Reply-To:References:Organization: Content-Type:Content-Transfer-Encoding:User-Agent:MIME-Version; bh=CgwyrB8Jb5pUosHEZFJFY9/cLdpnbCFAPhdRKUeAQ+U=; b=sw3jIeJym3QQF ea3H6ZJWi3e/qGuYDJRyUk64IxgqHDcOZVddx6itW0P4hc9Gb9ZeKa9+pvVV29jX d/p8cL7WP4yjcZoDhyeYJWM+hhAveKLEbREyBFRMUHzpyvp6MM+UvLym6vA92Ezp KTgO9WgCAK1bHoOPsne+/ac0cYzcuxbRg0r8hYIFm1WvFzScoZCFwJchBTM3sbww 65X92MLIlTTD4U/6k9W2igClZJMzuaRnqY7LNguSP4XuaEw3fgRgSeKr1P+OQrB0 z3Ac2YdXS5fhUwX2ULC8HVov5wkmrV6VqOcup1AnrJxSEFuhmhV8/EgVeu5MZO9i OxPZx3dxg== X-MDAV-Result: clean X-MDAV-Processed: gtd-gmbh.de, Thu, 13 Apr 2023 16:39:26 +0200 Received: by gtd-gmbh.de (MDaemon PRO v21.0.3) with ESMTPSA id md5001018116430.msg; Thu, 13 Apr 2023 16:39:25 +0200 X-Spam-Processed: gtd-gmbh.de, Thu, 13 Apr 2023 16:39:25 +0200 (not processed: message from trusted or authenticated source) X-MDRemoteIP: 109.90.104.197 X-MDArrival-Date: Thu, 13 Apr 2023 16:39:25 +0200 X-Authenticated-Sender: andoni.arregui@gtd-gmbh.de X-Return-Path: prvs=1467722fc7=andoni.arregui@gtd-gmbh.de X-Envelope-From: andoni.arregui@gtd-gmbh.de X-MDaemon-Deliver-To: newlib@sourceware.org Message-ID: Subject: Re: [PATCH 0/4] Fix huge error for pow detected by Paul Zimmermann From: Andoni Arregi Reply-To: andoni.arregui@gtd-gmbh.de To: Paul Zimmermann Cc: newlib@sourceware.org Date: Thu, 13 Apr 2023 16:39:22 +0200 In-Reply-To: References: <20230412153445.161047-1-andoni.arregui@gtd-gmbh.de> Organization: GTD GmbH Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.4 MIME-Version: 1.0 X-MDCFSigsAdded: gtd-gmbh.de X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,BODY_8BITS,DKIM_INVALID,DKIM_SIGNED,KAM_DMARC_STATUS,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Dear Paul, thank *you* for detecting the errors/inaccuracies first (questions are as i= mportant as the answers) and then independently confirming that the patch solves them. You know how tricky this is and how easy it is to fix something here and br= eak it there. That's why such an independent verification in addition to our tests is so important :-) By the way, most of the submitted work is product of the effort of our coll= eague Fabian Schriever. Best regards On Thu, 2023-04-13 at 14:16 +0200, Paul Zimmermann wrote: > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 Hi Andoni, >=20 > I had time to check this patch series on top of be2749c. >=20 > I confirm the issue I reported is fixed. >=20 > In addition, the maximal known error, which was 636 ulps > apart from the above issue, has dropped to less than 1 ulp: >=20 > pow 0 -1 0x1.4c3064d46aef3p-851,-0x1.cef4118ed50c2p-10 [0.893] 0.892119 0= .8921192373561432 >=20 > Thank you, great work! >=20 > Paul >=20 > > From: Andoni Arregi > > Cc: Andoni Arregi > > Date: Wed, 12 Apr 2023 17:34:41 +0200 > >=20 > > This patch series fixes in pow the huge error detected by Paul > > Zimmermann where x is negative and y is a large odd integer. > >=20 > > There is also an accuracy fix for cases where x is close to 1 and y is > > large. > >=20 > > Andoni Arregi (4): > > =C2=A0 Fix missing sign for overflow/underflow where x is negative and = y is > > =C2=A0=C2=A0=C2=A0 large odd integer > > =C2=A0 Fix x close to 1, y between 2^31 and 2^64 > > =C2=A0 Compare j as unsigned > > =C2=A0 Replace always true if with else > >=20 > > =C2=A0newlib/libm/math/e_pow.c | 48 +++++++++++++++++++++--------------= ----- > > =C2=A01 file changed, 25 insertions(+), 23 deletions(-) > >=20 > > --=20 > > 2.40.0 > >=20 > >=20 > >=20 --=20 Andoni Arregi Gesch=C3=A4ftsf=C3=BChrer =20 GTD GmbH Ravensburger Str. 32a, 88677 Markdorf T: +49 7544 96440 22 | M: +49 151 65620499 | F: +49 7544 96440 29 http://www.gtd-gmbh.de andoni.arregi@gtd-gmbh.de