public inbox for newlib@sourceware.org
 help / color / mirror / Atom feed
From: "Maciej W. Rozycki" <macro@embecosm.com>
To: newlib@sourceware.org
Cc: Kito Cheng <kito.cheng@gmail.com>
Subject: [PATCH] RISC-V: Fix floating-point environment support for soft float
Date: Fri, 27 Jan 2023 08:53:35 +0000 (GMT)	[thread overview]
Message-ID: <alpine.DEB.2.20.2301270123150.7841@tpp.orcam.me.uk> (raw)

We don't have floating-point exception or non-default rounding mode 
support for the RISC-V soft-float environment, `feraiseexcept' and 
`fesetround' do nothing unless the `__riscv_flen' macro has been set. 
Therefore following ISO C language requirements[1] only define macros 
for soft float that correspond to actually supported floating-point 
environment features, removing failures from GCC testing such as:

FAIL: gcc.dg/torture/fp-int-convert-timode-3.c   -O0  execution test
FAIL: gcc.dg/torture/fp-int-convert-timode-4.c   -O0  execution test

References:

[1] "Programming languages -- C", ISO/IEC 9899:2023, working draft --
    September 3, 2022, Section 7.6 "Floating-point environment <fenv.h>"

Fixes: 7040b2de0883 ("Add RISC-V port for libm")
Signed-off-by: Maciej W. Rozycki <macro@embecosm.com>
---
 newlib/libc/machine/riscv/sys/fenv.h |    9 +++++++++
 1 file changed, 9 insertions(+)

newlib-riscv-fenv-soft-float.diff
Index: newlib/newlib/libc/machine/riscv/sys/fenv.h
===================================================================
--- newlib.orig/newlib/libc/machine/riscv/sys/fenv.h
+++ newlib/newlib/libc/machine/riscv/sys/fenv.h
@@ -14,6 +14,8 @@
 
 #include <stddef.h>
 
+#if __riscv_flen
+
 /* Per "The RISC-V Instruction Set Manual: Volume I: User-Level ISA:
  * Version 2.1", Section 8.2, "Floating-Point Control and Status
  * Register":
@@ -69,6 +71,13 @@
  * floating-point unit."
  */
 
+#else /* !__riscv_flen */
+
+#define FE_ALL_EXCEPT   0x00000000
+#define FE_TONEAREST    0x00000000
+
+#endif /* !__riscv_flen */
+
 typedef size_t fenv_t;
 typedef size_t fexcept_t;
 extern const fenv_t fe_dfl_env;

             reply	other threads:[~2023-01-27  8:53 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-27  8:53 Maciej W. Rozycki [this message]
2023-01-27  9:08 ` Kito Cheng
2023-01-27 13:26 ` Corinna Vinschen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.20.2301270123150.7841@tpp.orcam.me.uk \
    --to=macro@embecosm.com \
    --cc=kito.cheng@gmail.com \
    --cc=newlib@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).