public inbox for newlib@sourceware.org
 help / color / mirror / Atom feed
From: Richard Earnshaw <Richard.Earnshaw@foss.arm.com>
To: Mike Frysinger <vapier@gentoo.org>,
	"Victor L. Do Nascimento" <victor.donascimento@arm.com>
Cc: newlib@sourceware.org, richard.earnshaw@arm.com
Subject: Re: [PATCH] libc: arm: fix setjmp abi non-conformance
Date: Fri, 3 Feb 2023 13:09:17 +0000	[thread overview]
Message-ID: <b2cbe4bd-7c31-36cc-0f9e-38e02a979415@foss.arm.com> (raw)
In-Reply-To: <Y9Eu+ya/PXTGJfKd@vapier>



On 25/01/2023 13:30, Mike Frysinger wrote:
> On 13 Dec 2022 14:51, Victor L. Do Nascimento wrote:
>> As per the arm Procedure Call Standard for the Arm Architecture
>> section 6.1.2 [1], VFP registers s16-s31 (d8-d15, q4-q7) must be
>> preserved across subroutine calls.
>>
>> The current setjmp/longjmp implementations preserve only the core
>> registers, with the jump buffer size too small to store the required
>> co-processor registers.
>>
>> In accordance with the C Library ABI for the Arm Architecture
>> section 6.11 [2], this patch sets _JBTYPE to long long adjusting
>> _JBLEN to 20.
>>
>> It also emits vfp load/store instructions depending on architectural
>> support, predicated at compile time on ACLE feature-test macros.
> 
> this breaks building with GCC 11 and older:
> https://bugs.gentoo.org/891589#c7
> 
> i don't think it was intentional that this only work with GCC 12+, or if
> it was, that we want such requirements.  GCC 12 is less than a year old.
> -mike

This has been fixed with commit c6e601de84ea9f2be2b026c609cc3c1fe82a3103.

  reply	other threads:[~2023-02-03 13:09 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-13 14:51 Victor L. Do Nascimento
2022-12-13 15:54 ` Richard Earnshaw
2023-01-25 13:30 ` Mike Frysinger
2023-02-03 13:09   ` Richard Earnshaw [this message]
2023-02-07 15:24     ` Victor Do Nascimento
2023-02-07 15:30       ` Richard Earnshaw
2023-02-07 21:45       ` Jeff Johnston

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b2cbe4bd-7c31-36cc-0f9e-38e02a979415@foss.arm.com \
    --to=richard.earnshaw@foss.arm.com \
    --cc=newlib@sourceware.org \
    --cc=richard.earnshaw@arm.com \
    --cc=vapier@gentoo.org \
    --cc=victor.donascimento@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).