From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from omta002.cacentral1.a.cloudfilter.net (omta002.cacentral1.a.cloudfilter.net [3.97.99.33]) by sourceware.org (Postfix) with ESMTPS id 00CD2384DD39 for ; Mon, 20 Feb 2023 20:25:22 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 00CD2384DD39 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=Shaw.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=shaw.ca Received: from shw-obgw-4001a.ext.cloudfilter.net ([10.228.9.142]) by cmsmtp with ESMTP id U9Y2pZEfZjvm1UCiwpWrLL; Mon, 20 Feb 2023 20:25:22 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=shaw.ca; s=s20180605; t=1676924722; bh=vr9DjEnINx3Q1i92/Dw3zel6QBVUxLkvNdOXurE7S6I=; h=Date:Reply-To:Subject:To:References:From:In-Reply-To; b=pByxjkK1qtnpKCfrTfdzrkkYRnKo7ajdOlrOsQhDj/et1wrfEfs1zO+piUNtajfyw ZIZa/ykIlA5jpmOieKeM95tRxi6trSdCmaSW8aETYYn51yMuCXVGet0ao8V1kemaH6 PJ7ezUxn0BnBxB6BOJQfhA4fLpSQuoQWZJYTaprpiQ5mD0KNT3mHH9efVEoMqk+Z0C atUYa2c3FB/2XlBoThYZmoblzeo3on5ggykrRwBSXlvbiu6eQYNT8VyXezhqc3Y07A gEOJXR77Km7Z7MrN2hMU0HypIReTuWvUmsq736sjfhQi3+54RIenpwvToJFvlFuwXr hcjM7jcdvzN5Q== Received: from [10.0.0.5] ([184.64.102.149]) by cmsmtp with ESMTP id UCivp0RJ3HFsOUCivpd7Bq; Mon, 20 Feb 2023 20:25:22 +0000 X-Authority-Analysis: v=2.4 cv=XZqaca15 c=1 sm=1 tr=0 ts=63f3d732 a=DxHlV3/gbUaP7LOF0QAmaA==:117 a=DxHlV3/gbUaP7LOF0QAmaA==:17 a=IkcTkHD0fZMA:10 a=4Y1Rd2-blNqR5Fx8IhwA:9 a=QEXdDO2ut3YA:10 Message-ID: Date: Mon, 20 Feb 2023 13:25:21 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.7.2 Reply-To: newlib@sourceware.org Subject: Re: [PATCH 0/2] newlib/libc/time/strftime: table format fix man, tbl, groff multi-page table issues Content-Language: en-CA To: newlib@sourceware.org References: <20230217204902.3735-1-Brian.Inglis@Shaw.ca> From: Brian Inglis Organization: Inglis In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-CMAE-Envelope: MS4xfORqHaiorJ4Qe1sqRrHvFMwx3ykZaIXWmgxeCWKmyZG+4IS1zRRb4McAPUCbH0HQ+T5QvIDoDKQDzBMpg37vmhr+8oqkWM8m1eRaoIfXi/T1nwXp3Okp T5i3x2Sh0YmO+fe/3mkHnPs5LwAwn3wbIS23P2X95WKCu0X8pqxiHCTB/iVtBfuzpUiKfSCBA5QD4g== X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2023-02-20 02:45, Corinna Vinschen wrote: > Hi Brian, > > On Feb 17 13:49, Brian Inglis wrote: >> Brian Inglis (2): >> newlib/libc/time/strftime.c: split table of conversion >> specifiers to fix man, tbl, groff multi-page table issues >> newlib/libc/Makefile.inc: sed fix strftime.3 table format >> man, tbl, groff multi-page issues >> >> newlib/libc/time/strftime.c | 3 ++- >> newlib/libc/Makefile.inc | 1 + >> 2 files changed, 3 insertions(+), 1 deletion(-) >> >> -- >> 2.39.0 > > Would you mind terribly to add more text to the commit messages? > explaining the problem, and its fix? Just the subject line is quite > terse. > > For patch 1, why adding the split and what's the desired effect. For > patch 2, what problem is the sed call fixing and what is the sed > expression doing? Thanks Corinna, You're right - will redo all v3. -- Take care. Thanks, Brian Inglis Calgary, Alberta, Canada La perfection est atteinte Perfection is achieved non pas lorsqu'il n'y a plus rien à ajouter not when there is no more to add mais lorsqu'il n'y a plus rien à retirer but when there is no more to cut -- Antoine de Saint-Exupéry