From: Alexey Lapshin <alexey.lapshin@espressif.com>
To: "newlib@sourceware.org" <newlib@sourceware.org>
Cc: Alexey Gerenkov <alexey.gerenkov@espressif.com>,
Ivan Grokhotkov <ivan@espressif.com>
Subject: [PATCH] libc: fix __time_load_locale return code
Date: Thu, 11 May 2023 06:32:49 +0000 [thread overview]
Message-ID: <b80602dfff7997624e266286ee236671082be13b.camel@espressif.com> (raw)
newlib:
* libc/locale/timelocal.c: ret variable could have garbage
because
not initialized. explicit check for __HAVE_LOCALE_INFO__
---
newlib/libc/locale/timelocal.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/newlib/libc/locale/timelocal.c
b/newlib/libc/locale/timelocal.c
index 4b361544a..04ae1142f 100644
--- a/newlib/libc/locale/timelocal.c
+++ b/newlib/libc/locale/timelocal.c
@@ -147,10 +147,11 @@ int
__time_load_locale (struct __locale_t *locale, const char *name,
void *f_wctomb, const char *charset)
{
- int ret;
+ int ret = 0;
struct lc_time_T ti;
char *bufp = NULL;
+#ifdef __HAVE_LOCALE_INFO__
#ifdef __CYGWIN__
extern int __set_lc_time_from_win (const char *, const struct
lc_time_T *,
struct lc_time_T *, char **, void
*,
@@ -186,5 +187,6 @@ __time_load_locale (struct __locale_t *locale,
const char *name,
#else
/* TODO */
#endif
+#endif /*__HAVE_LOCALE_INFO__*/
return (ret);
}
--
2.34.1
next reply other threads:[~2023-05-11 6:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-11 6:32 Alexey Lapshin [this message]
2023-05-15 16:30 ` [PATCH v2] " Alexey Lapshin
2023-05-17 19:37 ` Jeff Johnston
2023-05-17 21:49 ` Jeff Johnston
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b80602dfff7997624e266286ee236671082be13b.camel@espressif.com \
--to=alexey.lapshin@espressif.com \
--cc=alexey.gerenkov@espressif.com \
--cc=ivan@espressif.com \
--cc=newlib@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).