From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by sourceware.org (Postfix) with ESMTP id AA9633858C5F for ; Fri, 10 Feb 2023 11:21:02 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org AA9633858C5F Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=foss.arm.com Authentication-Results: sourceware.org; spf=none smtp.mailfrom=foss.arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id E1EA72F4; Fri, 10 Feb 2023 03:21:44 -0800 (PST) Received: from [10.2.78.76] (e126323.cambridge.arm.com [10.2.78.76]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id BD6AC3F8C6; Fri, 10 Feb 2023 03:21:01 -0800 (PST) Message-ID: Date: Fri, 10 Feb 2023 11:21:00 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: Various libgloss problems after recent changes Content-Language: en-GB To: Jeff Johnston , Jeff Law Cc: Mike Frysinger , newlib@sourceware.org References: From: Richard Earnshaw In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3490.1 required=5.0 tests=BAYES_00,KAM_DMARC_STATUS,KAM_LAZY_DOMAIN_SECURITY,NICE_REPLY_A,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 09/02/2023 22:54, Jeff Johnston wrote: > Hi Jeff, > > Want to try out the attached patch? > > -- Jeff J. > > > On Sun, Feb 5, 2023 at 7:48 PM Jeff Law wrote: > >> The fr30-elf and xstormy16-elf ports have been failing to build for >> about a month with this error: >> >> > fr30-elf-as -I. -I../../../../..//newlib-cygwin/libgloss/fr30/.. >> -I./.. -idirafter >> ../../../../..//newlib-cygwin/libgloss/fr30/../../include -o crt0.o >> ../../../../..//newlib-cygwin/libgloss/fr30/crt0.s >>> fr30-elf-as: unrecognized option '-idirafter' >> >> >> For a full log: >> >> http://law-sandy.freeddns.org:8080/job/fr30-elf/1984/console >> >> Hopefully this is easy to fix so we can get those ports under regular >> testing again. >> >> Jeff >> >> I'm slightly confused. Why would some ports have -idirafter and some not, unless they're not using GCC (or a very old one). So wouldn't a autoconf test for -idirafter be a better approach rather than hard-coding it. Note that if it's due to the option not being supported in old versions of gcc, then that's a bigger problem because the reason the option was added in the first place (IIRC) was to support moving arm-acle-compat.h out of the newlib subdir so it could be used with libgloss. And arm-acle-compat.h is there to support older versions of GCC. And that brings up another question. Just how old a version of GCC do we want to support these days? ACLE support was added to GCC 10 years ago, in GCC-4.8. If we can drop support for compilers older than that, we can drop using the compatibility header and get rid of the need for -idirafter entirely. R.